fix(profile): make glob '*' match newlines so deny rules cannot fail open - #1420
Merged
Merged
Conversation
…open Compile profile glob patterns with the (?s) flag so '*' also matches embedded newlines in a tool identity. Also tighten the legacy round-trip test to assert byte equality, fix a mislabeled glob test case, and correct the node-fixture drift comment.
7 tasks
Deploying mcpproxy-docs with
|
| Latest commit: |
e1ec00c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8b28936a.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-low-1393-profile-policy.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 36565970847 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the still-actual items from the 108-a profile policy review follow-ups.
(?s)so*matches embedded newlines in a tool identity (a deny pattern such asgithub:delete*no longer fails open ongithub:delete\nrepo). Regression cases added first and confirmed failing.require.Equal), matching its doc comment.Not changed: items 4 and 5 are obsolete (the policy enforcement test override was removed in #1411); item 6 (REST-door test fake) is a low-value coverage gap left open.
Refs #1393