Move `check_attr` to attribute parsing by JonathanBrouwer · Pull Request #165693 · rust-lang/rust

JonathanBrouwer · 2026-11-09T12:03:31Z

Just cleanup, should not affect behaviour other than diagnostic ordering.

Can be reviewed commit by commit, every commit passes tests.
Is also small enough that reviewing as a whole is fine tho.

r? @mejrs

rustbot · 2026-11-09T12:03:34Z

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

JonathanBrouwer · 2026-11-09T12:21:28Z

@bors try @rust-timer queue
Just in case

Move `check_attr` to attribute parsing

rust-bors · 2026-11-09T13:20:57Z

☀️ Try build successful (CI)
Build commit: 1565052 (156505268747d9a7384984d749d4542a9b406226)
Base parent: fd4400d (fd4400dce238d263ff4239ac9eb902cb9547daf2)

rust-timer · 2026-11-09T16:03:15Z

Finished benchmarking commit (1565052): comparison URL.

Overall result: ❌✅ regressions and improvements - please read:

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

Next, please: If you can, justify the regressions found in this try perf run in writing along with @rustbot label: +perf-regression-triaged. If not, fix the regressions and do another perf run. Neutral or positive results will clear the label automatically.

@bors rollup=iffy rustc-perf
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	0.2%	[0.2%, 0.2%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	7
All ❌✅ (primary)	0.2%	[0.2%, 0.2%]	1

Max RSS (memory usage)

Results (secondary 3.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.9%	[3.4%, 4.5%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.9%	[-2.9%, -2.9%]	1
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 485.883s -> 488.063s (0.45%)
Artifact size: 406.18 MiB -> 406.24 MiB (0.01%)

mejrs

@bors r+ rollup

View changes since this review

rust-bors · 2026-11-09T21:32:02Z

📌 Commit fb94dbd has been approved by mejrs

It is now in the queue for this repository.

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

JonathanBrouwer · 2026-11-09T21:52:12Z

💔 I suspect this PR failed tests as part of a rollup
@bors r-

After fixing the problem, consider running a try job for the failed job before re-approving.

Link to failure: #165724 (comment)

rust-bors · 2026-11-09T21:52:21Z

This pull request was unapproved.

This PR was contained in a rollup (#165724), which was unapproved.

View changes since this unapproval

rustbot · 2026-11-10T07:01:57Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

JonathanBrouwer · 2026-11-10T07:02:53Z

@bors r=mejrs

rust-bors · 2026-11-10T07:02:56Z

📌 Commit 0a179cc has been tentatively approved by mejrs

It will be put into the queue for this repository once PR CI succeeds.

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165487 (Migrate built-in macros `pattern_type` & `view_type` to macros 2.0 that expand to internal syntax) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

…uwer Rollup of 16 pull requests Successful merges: - #165575 (Upgrade bundled musl to 1.2.6) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165117 (std: use skip_unsupported_miri_tests to control when tests should be skipped in Miri due to missing shims) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context) - #165709 (remove 'x miri' smoke test from PR CI)

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

@mejrs

Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

…uwer Rollup of 24 pull requests Successful merges: - #165709 (remove 'x miri' smoke test from PR CI) - #164217 (Prepare to make `rustc_trivial_field_reads` usable in user code) - #165569 (`Move` trait feature gate) - #165575 (Upgrade bundled musl to 1.2.6) - #163241 (Add enclosing item context when pointing at `FnMut` bound) - #163992 (add `core::arch::{x86, x86_64}::x87_f80`) - #165047 (Change the span building of paths from first-to-last to chained) - #165458 (fix incorrect byte count suffix on MSVC) - #165490 (Mark the compile unit for `-Zdebuginfo-for-profiling`) - #165586 (Remove `backend_optimization_level`.) - #165646 (fix NumScalableVectors::from_field_count) - #165655 (Unignore passing GCC backend tests) - #165740 (miri subtree update) - #165753 (avoid Terminator:None in MIR inliner) - #153261 (Partially stabilize `ptr_alignment_type` as `alignment_type`) - #164559 (Windows: fix Dir::remove and Dir::rename following symlinks) - #165562 (stop using gce in a test) - #165681 (Add safety requirements for Pattern and Searcher) - #165682 (interpret: ensure newly created unions have uninit in their padding) - #165693 (Move `check_attr` to attribute parsing) - #165715 (windows: check for null before wide encoding) - #165717 (mpsc_sync::stream_send_recv_stress: wait for all threads to finish) - #165733 (docs(num): remove needless whitespaces) - #165739 (remove NOP File::flush from fs tests) Failed merges: - #165727 (Normalize "beta release channel" in `const-supertrait-unstable` test) - #164218 (Tweak private re-export errors to point at correct span and have more context)

@mejrs

Rollup merge of #165693 - JonathanBrouwer:check-attr, r=mejrs Move `check_attr` to attribute parsing Just cleanup, should not affect behaviour other than diagnostic ordering. Can be reviewed commit by commit, every commit passes tests. Is also small enough that reviewing as a whole is fine tho. r? @mejrs

rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2026

rustbot assigned mejrs Nov 9, 2026

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Nov 9, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Nov 9, 2026

Auto merge of #165693 - JonathanBrouwer:check-attr, r=<try>

1565052

Move `check_attr` to attribute parsing

mejrs reviewed Nov 9, 2026

View reviewed changes

Comment thread compiler/rustc_attr_parsing/src/interface.rs Resolved

Comment thread compiler/rustc_ast_passes/src/ast_validation.rs Resolved

JonathanBrouwer force-pushed the check-attr branch from 6be3e64 to fb94dbd Compare November 9, 2026 13:20

This comment has been minimized.

Sign in to view

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Nov 9, 2026

mejrs approved these changes Nov 9, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2026

JonathanBrouwer mentioned this pull request Nov 9, 2026

Rollup of 7 pull requests #165724

Closed

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 9, 2026

Remove parsed arm of check_attr

2fa016a

JonathanBrouwer force-pushed the check-attr branch from fb94dbd to dac9297 Compare November 10, 2026 07:01

JonathanBrouwer added 2 commits November 10, 2026 08:02

Move check_attr to attribute parsing

6fd528c

Add test checking that the behaviour for diagnostic attrs is preserved

0a179cc

JonathanBrouwer force-pushed the check-attr branch from dac9297 to 0a179cc Compare November 10, 2026 07:02

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 10, 2026

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 14 pull requests #165742

Closed

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 16 pull requests #165747

Closed

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 16 pull requests #165752

Closed

JonathanBrouwer mentioned this pull request Nov 10, 2026

Rollup of 23 pull requests #165756

Closed

This was referenced Nov 10, 2026

Rollup of 24 pull requests #165759

Closed

Rollup of 24 pull requests #165760

Merged

rust-bors Bot merged commit b9c6c8c into rust-lang:main Nov 10, 2026
14 checks passed

rustbot added this to the 1.102.0 milestone Nov 10, 2026

Conversation

JonathanBrouwer commented Nov 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

This comment has been minimized.

rust-timer commented Nov 9, 2026

Overall result: ❌✅ regressions and improvements - please read:

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

mejrs left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

JonathanBrouwer commented Nov 9, 2026

Uh oh!

rust-bors Bot commented Nov 9, 2026

Uh oh!

rustbot commented Nov 10, 2026

Uh oh!

JonathanBrouwer commented Nov 10, 2026

Uh oh!

rust-bors Bot commented Nov 10, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

JonathanBrouwer commented Nov 9, 2026 •

edited

Loading

mejrs left a comment •

edited by rustbot

Loading