Skip to content

builder: optionally check queue length before builds & limit max prio - #3676

Merged
GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:builder-queue-limit
Nov 5, 2026
Merged

GuillaumeGomez merged 1 commit into
rust-lang:mainfrom
syphar:builder-queue-limit

Conversation

@syphar

@syphar syphar commented Nov 5, 2026

Copy link
Copy Markdown
Member

When digging into webserver performance issues on our legacy instance I saw one thing: running builds might make the webserver slower.

Since:

  • we have lower-prio builds like automated rebuilds that can take / wait longer, and
  • even for normal builds it doesn't matter if they wait a minute more or less

I thought about this feature, where we would deactivate initially 2 of the 6 builders if the queue is short enough. Also, these would only be used for release builds, not automated rebuilds.

Both the min-queue-length and the max-priority for these additional builders can be configured.

With the new infra we might not need this any more, since we have separate EC2 instances for each builder, and we can autoscale them.

But as long as that migration is not finished, I would like the option to reduce build speed, when it impacts the webserver too much, and while keeping the additional builders configured for "queue is full" situations.

@syphar syphar self-assigned this Nov 5, 2026
@syphar
syphar requested a review from a team as a code owner November 5, 2026 12:37
@github-actions github-actions Bot added S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 5, 2026
@syphar

syphar commented Nov 5, 2026

Copy link
Copy Markdown
Member Author

r? @GuillaumeGomez

@rustbot rustbot assigned GuillaumeGomez and unassigned syphar Nov 5, 2026
@syphar
syphar requested a review from GuillaumeGomez November 5, 2026 13:19
@GuillaumeGomez

Copy link
Copy Markdown
Member

Thanks!

@GuillaumeGomez
GuillaumeGomez enabled auto-merge (rebase) November 5, 2026 13:51
@GuillaumeGomez
GuillaumeGomez merged commit c916589 into rust-lang:main Nov 5, 2026
18 checks passed
@GuillaumeGomez
GuillaumeGomez deleted the builder-queue-limit branch November 5, 2026 13:51
@github-actions github-actions Bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Nov 5, 2026

This branch was previously deployed

1 inactive deployment
github-pages — eb445776 Deployed Nov 5, 2026 by GuillaumeGomez via deploy #911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants