Repository navigation
Conversation
github-actions
Bot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
syphar
marked this pull request as draft
November 5, 2026 14:00
syphar
force-pushed
the
queue-build-lock
branch
from
November 5, 2026 14:06
27fe281 to
7da1d80
Compare
syphar
force-pushed
the
queue-build-lock
branch
from
November 5, 2026 14:07
7da1d80 to
130151c
Compare
syphar
marked this pull request as ready for review
November 5, 2026 14:07
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
most of the time when I lock the queue, I actually just want to lock builds. So we can split that out.
Separate factor:
with the recent thread-count problems our builders were locking the queue on errors with toolchain maintenance. This is unnecessary, it's totally fine just to lock builds and let registry fetching continue. This avoids confusion for crate authors that are searching for their new release, see #3675