Repository navigation
Avoid unnecessary archive-index lookups and retries for releases without documentation. - #3673
Merged
Merged
Conversation
github-actions
Bot
added
the
S-waiting-on-review
syphar
marked this pull request as ready for review
November 3, 2026 14:18
Member
Author
Co-authored-by: Guillaume Gomez <[email protected]>
GuillaumeGomez
approved these changes
Nov 3, 2026
Member
|
Thanks! |
github-actions
Bot
added
S-waiting-on-deploy
syphar
removed
the
S-waiting-on-deploy
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This week I'm fighting a new crawler with a traffic pattern that brings our webserver to its limits, and even broke the build servers last night.
Here the first of some more optimizations.
Target redirects for releases without docs
The rustdoc version dropdown generated target-redirect links for every release, including failed builds and binary crates.
Previously, following one of these links loaded crate details and checked storage for a rustdoc archive index. When the index was missing, the handler eventually redirected to a rustdoc search URL,
which redirected again to crate details.
Now:
rustdoc_statusand redirect directly to crate details before loading additional crate details or accessing storage.Retrying missing archive indexes
The archive-index cache treated a confirmed storage
PathNotFoundErroras a potentially repairable failure. It retried up to five times, including local cache purges and repeated download attempts.Now, confirmed missing-index errors return immediately. Other failures retain the existing repair and retry behavior.
Under crawler load, the previous behavior amplified storage requests, filesystem operations, and warning logs for unavailable documentation.