Repository navigation
migrate archive index from sqlx / sqlite to rusqlite & separate threadpool - #3674
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
syphar
marked this pull request as ready for review
November 5, 2026 10:57
GuillaumeGomez
approved these changes
Nov 5, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
During crawler-driven traffic peaks, the docs.rs daemon reached roughly 12,000 threads and 19,000 open file descriptors. Requests slowed down, PostgreSQL pool acquisition times increased, and SQLite connection initialization failed with
Resource temporarily unavailable. This problem lead to unplanned daemon restarts, and also build-servers stopping to build.Archive indexes currently use SQLx, which runs a dedicated worker thread for each SQLite connection. We open a connection per index lookup, so concurrent requests can create thousands of SQLite worker threads. Slow directory listings and connection initialization can further increase the number of requests—and connections—alive simultaneously.
The investigation also found contention from builds sharing the host. This change addresses the SQLite thread growth; it does not establish that SQLite was the sole cause of the PostgreSQL pool pressure.
Approach
Replace SQLx archive-index access with synchronous rusqlite operations scheduled on a dedicated, fixed-size Rayon pool shared by the archive-index cache.
This separates SQLite connection lifetime from worker-thread lifetime. Connections can remain open without retaining a dedicated thread, while excess SQLite work queues behind the configured workers.
A dedicated pool also keeps this work separate from Tokio's blocking pool. Connection pooling could reduce initialization costs later, but is not required to bound SQLite worker threads.
Changes
DOCSRS_ARCHIVE_INDEX_THREADS(default: 32).spawn_blocking.This bounds worker threads, not the number of queued requests or open connections.