Repository navigation
End feature-planning at the spec merge; tickets come from spec-tickets - #2886
Conversation
Drop decompose, issues and issue-coverage from the planning line, the base start item they read, the feature-decompose prompt, and the delivering page state. The coverage station moves under spec-tickets. Specs 7-feature-planning and external-floor now say where tickets come from.
|
Lore is reviewing this PR — e5f9f6ab-feff-486c-9154-207e56cc6151. Submit a review that requests changes to have Lore push a fix for it. Comment |
Lore Spec ImpactLore API unreachable (HTTP 000000). This check could not run. |
![lore-agent[bot]](https://avatars.githubusercontent.com/u/141229953?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lore review — Changes suggested
Rewriting FR8.7 in specs/external-floor/spec.md dropped the four specPathOfPlan test links, failing CI's orphaned-tests check.
Must fix (1) · Consider (1) · Nits (3)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Notes on lines outside changed hunks
apps/lore-api/src/work/plans/floor-plan-line.ts:62 — nit: Remove stranded baseBranch JSDoc comment above specPrState
/** What GitHub says of a spec PR now, so a later pass is briefed as the amendment it is; null when the PR is gone. */
apps/stations/src/spec-tickets/issue-coverage/station.ts:226 — nit: Rename unused startIssueCoverageStation to startSpecTicketsCoverageStation (or remove it) to match spec-tickets/index.ts
export function startSpecTicketsCoverageStation(): RunningStation {
return defineStation(
"spec-tickets-coverage",
issueCoverageHandle(coverageDeps),
);
}
Posted by floor, visit fc1fc5db-45d6-43bd-a169-5521e06f28f6.
There was a problem hiding this comment.
Lore review — Approved
Latest commit cleanly restores implementation-loop spec links and links the spec-plan-path tests; spec-links and orphaned-tests checks pass with no new issues.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit 0d764000-baa5-4a42-9c10-4caf07e56537.
There was a problem hiding this comment.
Lore review — Approved
Spec prose and link-group formatting updates in c7f9af6 resolve the prior review items cleanly.
Must fix (0) · Consider (0) · Nits (1)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit 2f3a556b-fd12-4b7a-aa3d-107981be6ac7.
There was a problem hiding this comment.
Lore review — Approved
Spec presence label list updated to drop '(splitting into tasks)', matching AGENT_STEPS.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit eed1afa8-05eb-48d1-9064-92066cc6b41d.
The feature-planning line stopped filing tickets in #2886 and its feature-decompose.md default was deleted; the spec-tickets line has its own spec-tickets-decompose agent. The boot seed only fills rows from files that exist, so the org row it wrote earlier (and any per-repo override) stays behind with nothing reading it. Migration 0113 deletes those rows. Unlike 0094 it records no catalog event: lore.catalog_events went away with the cluster agents that read it, which the DB Migrations job caught on the first attempt. It is a no-op on a database without the row. Tested by the DB Migrations job applying the baseline and every migration, this one included, and by the migrations guard in apps/lore-api/src/migrations.test.ts.
…ecks a node's needs, the seed logs the floor's reasons (#3518) Since #2886 the floor refused every version of the `feature-planning` line: `plan-grounding` and `validate` still bind `target: base`, and #2886 removed the `base` arg with the ticketing nodes that also read it. lore-api logged only `invalid line body`, so the floor kept the pre-#2886 line for four days and nothing shipped for feature-planning since 10-22 reached it, #3466's prompts and pod sizes included. What changes: - `feature-planning.yaml` declares `base: {kind: git}` again, and lore-api seeds the `base` start item again (`baseBranch` on `FloorPlanDeps`, the default branch), as before #2886. - `pipelineProblems` gains `unseeded-need`, the floor's own check from its `line-needs.ts`: a required need, under the bag name the node binds it to, must be seeded by the line, a git need only by a git arg. The shipped-pipelines test fails on today's `main` with the floor's two exact sentences, so a bind to a removed arg fails CI rather than a production boot. (The floor also asks for a producer on every path into the node; the lint stops at "something in the line".) - `seedFloorPipelines` reports the floor's problem list beside the 400's title, so the boot log says which node and which bag item, not just "invalid line body". - FR-20 of `specs/7-feature-planning` gets the statement and its links. Verified by replaying both files through the floor's `lineBodySchema` + `validateLine`: `main`'s file yields the two problems, this branch's yields none. Closes #3487 Related: #2886, #3466 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Follows #2884. The feature-planning line stops when its spec PR merges: decompose, issues and issue-coverage are gone from it, so the spec-tickets line is the only thing that files a spec's tickets and a planned spec is no longer ticketed twice.
Removed: the three nodes and their stations, the base start item they read, planning's feature-decompose prompt (spec-tickets-decompose replaces it), the planning-side issues station adapter, the delivering plan page state and its phase texts. The issue-coverage station and its tests move under apps/stations/src/spec-tickets/. The shared filing code stays, since issue-triage and spec-tickets use it.
Specs 7-feature-planning and external-floor now say where tickets come from; specs/spec-tickets gains the filing and agent statements.