Skip to content

Remove the retired feature-decompose agent definition rows - #2904

Merged
gedaiu merged 2 commits into
mainfrom
drop-feature-decompose-agent
Oct 22, 2026
Merged

gedaiu merged 2 commits into
mainfrom
drop-feature-decompose-agent

Conversation

@gedaiu

@gedaiu gedaiu commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

The feature-planning line stopped filing tickets in #2886 and its feature-decompose.md default was deleted; the spec-tickets line has its own spec-tickets-decompose agent. The boot seed only fills rows from files that exist, so the org row it wrote earlier (and any per-repo override) stays behind with nothing reading it.

Migration 0113 deletes those rows. Unlike 0094 it records no catalog event: lore.catalog_events went away with the cluster agents that read it, which the DB Migrations job caught on the first attempt. It is a no-op on a database without the row.

Tested by the DB Migrations job applying the baseline and every migration, this one included, and by the migrations guard in apps/lore-api/src/migrations.test.ts.

@lore-agent

lore-agent Bot commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Lore is reviewing this PR — 691963fe-e632-4c31-81eb-26278050813f.

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

@github-actions

Copy link
Copy Markdown
Contributor

🔍 Lore Spec Impact

Examined 1 changed file(s): 0 had graph data (no coupling found), 1 had none — no ingested test run covers them, so this check cannot speak for them.

Deterministic · graph @ 54e00aa (projected 2026-10-07) · no tests run by this check

@lore-agent lore-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lore review — Approved

Migration 0113 drops the INSERT into the removed lore.catalog_events table and cleanly deletes the retired feature-decompose rows.

Must fix (0) · Consider (0) · Nits (0)

Reviewed by gemini-4-argon

Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.

Posted by floor, visit a643d7b9-d2c8-4ea0-8ea3-ba4e4d4356b7.

@gedaiu
gedaiu merged commit 7fa6d8d into main Oct 22, 2026
37 checks passed
@gedaiu
gedaiu deleted the drop-feature-decompose-agent branch October 22, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant