Repository navigation
Add spec-tickets line: tickets from every merged spec - #2884
Conversation
|
Lore is reviewing this PR — fe1525ca-986a-4217-8a74-bffddbcf5cfe. Submit a review that requests changes to have Lore push a fix for it. Comment |
Lore Spec ImpactLore API unreachable (HTTP 413). This check could not run. |
4407324 to
2377d7a
Compare
![lore-agent[bot]](https://avatars.githubusercontent.com/u/141229953?s=60&v=4){kind=small}
There was a problem hiding this comment.
Lore review — Changes suggested
Adding spec-tickets-decompose.md breaks agent-defaults-files.test.ts in CI (31 vs 30 shipped agents), and wiring floorSpecTicketsHandlers onto github.pull_request.closed while feature-planning still runs decompose/issues after merged files duplicate ticket sets on every plan spec merge.
Must fix (2) · Consider (2) · Nits (0)
Reviewed by gemini-4-argon, gemini-3-flash-preview
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Notes on lines outside changed hunks
apps/stations/src/events/handlers.ts:207 — issue (blocking): Stop feature-planning at merged or avoid starting spec-tickets while feature-planning still runs decompose -> issues on github.pull_request.closed, which files two sets of issues (<plan_id> and spec-) for one merged spec PR
Posted by floor, visit ab212ce9-edde-4b2b-8772-7ffcdceeacf8.
There was a problem hiding this comment.
Lore review — Approved
New commits cleanly resolve the shipped agent-defaults count and duplicate handler import after rebase.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit 782a7e3a-86c5-4f10-93d8-6f0a41f3752d.
A merged specs/<name>/spec.md starts one spec-tickets run on the floor (load-tickets, decompose, issues, issue-coverage). The spec's filing key stands where a plan id does, so a later merge of the same spec rewrites the issues the earlier run filed.
…comments on spec runs
2377d7a to
a01017e
Compare
There was a problem hiding this comment.
Lore review — Approved
Shipped specs and link-only upkeep diffs are skipped, story coverage comments are verified on spec-tickets runs, and shifted test links are updated.
Must fix (0) · Consider (0) · Nits (0)
Reviewed by gemini-4-argon
Submit a review that requests changes to have Lore push a fix for it. Comment @lore review to re-run the review.
Posted by floor, visit 857a4f18-26f0-4724-ae8b-84337bb80859.
#2886) Follows #2884. The feature-planning line stops when its spec PR merges: decompose, issues and issue-coverage are gone from it, so the spec-tickets line is the only thing that files a spec's tickets and a planned spec is no longer ticketed twice. Removed: the three nodes and their stations, the base start item they read, planning's feature-decompose prompt (spec-tickets-decompose replaces it), the planning-side issues station adapter, the delivering plan page state and its phase texts. The issue-coverage station and its tests move under apps/stations/src/spec-tickets/. The shared filing code stays, since issue-triage and spec-tickets use it. Specs 7-feature-planning and external-floor now say where tickets come from; specs/spec-tickets gains the filing and agent statements.
A pull request that merges a specs//spec.md into the default branch now starts one spec-tickets run per spec on the external floor. The run lists the tickets an earlier run filed for that spec, has an agent split the spec into stories and tasks (keeping the ids of tasks that are still the same work), files the story issue and task issues through the existing planning filing code, and counts the testable statements no task names.
Tickets are recognised by a filing key made of the spec's directory name, so a later merge of the same spec rewrites open tickets, leaves closed ones alone, closes tasks the spec dropped and adds new ones. Rejected and Retired specs, deleted specs, merges into a non-default branch and a redelivered merge with its run still open start nothing.
This only adds the line; the feature-planning line still files tickets until the follow-up PR removes that. Until the follow-up lands, a merged planned spec is ticketed by both lines under different keys, so the follow-up should merge right after this.
Spec: specs/spec-tickets/spec.md.