Repository navigation
fix(lifecycle): own Java debug JVMs and reject missing results - #343
Closed
Ajaymamtora wants to merge 2 commits into
Closed
Ajaymamtora wants to merge 2 commits into
Ajaymamtora wants to merge 2 commits into
Conversation
This was referenced Nov 13, 2026
Author
|
Withdrawing this upstream-targeted PR at my request. The same verified implementation has already been merged into my independently maintained fork in Ajaymamtora/neotest-java#1 (merge commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #342.
java/buildWorkspaceprotocol (boolean request, numeric status); propagate exceptions and explicit compiler failure before classpath resolution/JVM launch. Preserve documented nil-returning legacy synchronous compilers.vim.systemhandle. Bound JDWP readiness, post-debug exit/report waits and shutdown; detect split stdout/stderr banners and early exits. Add targeted, idempotent TERM/KILL, startup-abandonment and editor-exit cleanup without creating another JDTLS/debugger manager.Compatibility
launch_debug_teststill returnswait()/is_set()termination operations, now bounded, with additionalwait_ready,wait_exit,stop,claimand structuredstate. Injectable job runners must return the process handle fromstart()for cancellation support. Optionaldebug_startup_timeout_ms,debug_exit_timeout_ms,debug_shutdown_timeout_mstune deadlines. JUnit remains the existing standalone console runner; Java Debug/Test bundle ownership remains with JDTLS.Verification (local, not CI)
bash scripts/test: 225 cases, 33 groups, 0 failures; includes actual JVM spawn/JDWP/exit/kill integration, compile failure/deadline cases, abandoned startup/cancellation/concurrent process ownership, and real filesystem report-isolation/staleness regressions.bash tests/e2e/run-all.sh maven-simple: 2/2 files passed, snapshots matched (native harness uses its supplied LSP mocks; not claimed as real JDTLS evidence).stylua --check .: passed.luacheck lua/neotest-java: 0 warnings, 0 errors (41 files).lua-language-server --check . --checklevel=Warning: no problems.git diff --check: passed.qa.LifecycleTest#passing()at source line 9, stepped to 10, and hitqa.LegacyTest#vintagePass()at 6, stepped to 7. Cancellation while paused and failed attach both settled as failed infrastructure, reaped only their owned JVM, and removed owned reports.The real JDTLS gate also correctly rejected
buildWorkspace status 2with an actionable module error rather than running old classes. A forced-full build on a reopened Buildship workspace reported a prerequisite-project build-order error; the normal/default incremental workflow passed. This is recorded rather than hidden by swallowing compilation failure.Windows runtime was unavailable on this macOS host; no live Windows claim. Upstream architecture prose still describes the old event-only/fire-and-forget flow and can be refreshed separately. No GitHub Actions were inspected or used.