Skip to content

fix(lifecycle): integrate verified Java invocation ownership - #1

Merged
Ajaymamtora merged 2 commits into
mainfrom
fix/java-invocation-lifecycle
Nov 13, 2026
Merged

Ajaymamtora merged 2 commits into
mainfrom
fix/java-invocation-lifecycle

Conversation

@Ajaymamtora

@Ajaymamtora Ajaymamtora commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Owned fork integration

Integrate the exact verified head 2d485463069a1b7401416ddcdbb02ce4ef8260e9 for the consuming dotfiles project. Upstream issue remains open: rcasia#342. Upstream-targeted PR was withdrawn and closed without merge: rcasia#343.

Fork main and upstream main were fetched and both equal 30cbbd23e6dca0309500632052bc3fe2ba4c3d6d before merge; no source drift or unrelated commits are being integrated.

Fix

  • Reject thrown/explicit-false compilation failure and real JDTLS unsuccessful build status before launch.
  • Retain invocation-owned JVM process handles; bound readiness, process exit/report and shutdown waits; targeted idempotent cancellation, abandoned-start and editor-exit cleanup.
  • Unique reports per invocation; missing/stale/partial reports never imply success. Compatible synchronous/asynchronous Neotest DAP cleanup hooks.

Verified locally (no GitHub Actions)

  • Native suite: 225 cases, 33 groups, zero failures.
  • Native Maven E2E: 2/2 files, snapshots match (its LSP mocks are not live JDTLS evidence).
  • StyLua, Luacheck (41 files, zero warnings/errors), LuaLS and diff whitespace checks passed.
  • Real Mason JDTLS + Java Debug/Test, two-module Gradle 9.8.2 fixture: JUnit 4/5 Run and Debug pass/fail agree with authoritative XML, including parameterized/nested Jupiter results.
  • Real Jupiter breakpoint/step at lines 9/10; Vintage at 6/7. Cancellation while paused and failed attach both fail truthfully, settle boundedly, reap owned JVMs and remove owned reports.

Limits: Windows and live Maven multi-module were not exercised. Forced-full Buildship rebuild on a reopened workspace reported a prerequisite-project build-order error and was correctly rejected; default incremental workflow passed both complete live gates. Upstream has not merged the fix. It is maintained in this fork; upstream PR rcasia#343 was closed without merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant