Skip to content

Log smoke-all cleanup only on actual file removal #14721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cderv wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −2
Open

Log smoke-all cleanup only on actual file removal #14721

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fea03f
Log smoke-all cleanup only on actual file removal
cderv Jul 23, 2026
64b6386
Merge branch 'main' into fix/eliminate-spurious-cleaning-up-log-noise…
cderv Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tests/smoke/smoke-all.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ interface QuartoInlineTestSpec {
verifyFns: Verify[];
}

// Functions to cleanup leftover testing
// Functions to cleanup leftover testing.
// postRenderCleanupFiles is a module-global list swept by EVERY render
// teardown, so a registered entry only logs/removes at the teardowns where the
// file actually exists (its owning document), not on every subsequent teardown.
const postRenderCleanupFiles: string[] = [];
function registerPostRenderCleanupFile(file: string): void {
postRenderCleanupFiles.push(file);
Expand All @@ -168,8 +171,8 @@ const postRenderCleanup = () => {
return;
}
for (const file of postRenderCleanupFiles) {
console.log(`Cleaning up ${file} in ${Deno.cwd()}`);
if (safeExistsSync(file)) {
console.log(`Cleaning up ${file} in ${Deno.cwd()}`);
// recursive so a registered entry can be a directory (e.g. an embedded
// notebook's `*_files` support dir), not just a single file
safeRemoveSync(file, { recursive: true });
Expand Down
Loading