Log smoke-all cleanup only on actual file removal#14721
Open
cderv wants to merge 2 commits into
Open
Conversation
postRenderCleanupFiles is a module-global list swept by every render teardown. With the log statement outside the existence check, every teardown printed a "Cleaning up" line for each registered file whether or not it existed in that teardown's scope. Across a full serial run (~10 registered files x ~1600 teardowns) this emitted ~16k lines, almost all describing removals that never happened. Moving the log inside the safeExistsSync branch prints it only when a file is actually removed. Same files removed as before; only log frequency changes.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…-in-smoke-all-teardowns
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke-all test harness registers cleanup files in a module-global list that every render teardown sweeps. The
Cleaning up ...log line sat outside the existence check, so every teardown printed a line for each registered file whether or not it existed in that teardown's scope. With ~10 registered files across ~1600 teardowns, a full serial run emitted ~16k such lines, almost all describing removals that never happened.Moving the log inside the
safeExistsSyncbranch prints it only when a file is actually removed. Same files removed as before; only log frequency changes.