Skip to content

gh-154059: Fix Tachyon flame graph time units - #154036

Merged
pablogsal merged 5 commits into
python:mainfrom
pablogsal:agent/gh-154033-tachyon-flamegraph-time-units
Aug 11, 2026
Merged

gh-154059: Fix Tachyon flame graph time units#154036
pablogsal merged 5 commits into
python:mainfrom
pablogsal:agent/gh-154033-tachyon-flamegraph-time-units

Conversation

@pablogsal

@pablogsal pablogsal commented Jul 18, 2026

Copy link
Copy Markdown
Member

@pablogsal pablogsal added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 18, 2026
@pablogsal
pablogsal marked this pull request as ready for review July 18, 2026 23:49
@pablogsal pablogsal changed the title gh-154033: Fix Tachyon flame graph time units gh-154059: Fix Tachyon flame graph time units Jul 19, 2026
@pablogsal

Copy link
Copy Markdown
Member Author

CC: @lkollar

Comment thread Lib/profiling/sampling/_flamegraph_assets/flamegraph.js Outdated
Comment thread Lib/profiling/sampling/_flamegraph_assets/flamegraph.js
@python-cla-bot

This comment was marked as outdated.

@ivonastojanovic
ivonastojanovic force-pushed the agent/gh-154033-tachyon-flamegraph-time-units branch from a026674 to cd8f412 Compare July 21, 2026 14:48

@lkollar lkollar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal
pablogsal force-pushed the agent/gh-154033-tachyon-flamegraph-time-units branch from 36ab011 to f6b095f Compare August 11, 2026 22:49
@pablogsal
pablogsal enabled auto-merge (squash) August 11, 2026 22:52
@pablogsal
pablogsal merged commit ee68f5f into python:main Aug 11, 2026
51 checks passed
@pablogsal
pablogsal deleted the agent/gh-154033-tachyon-flamegraph-time-units branch August 11, 2026 23:16
@miss-islington-app

Copy link
Copy Markdown

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Aug 11, 2026

Copy link
Copy Markdown

GH-155597 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Aug 11, 2026
pablogsal added a commit that referenced this pull request Aug 12, 2026
…5597)

gh-154059: Fix Tachyon flame graph time units (GH-154036)
(cherry picked from commit ee68f5f)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tachyon flamegraph: Total time displayed is affected by sampling rate

3 participants