gh-155591: Fix flame graph sample-time conversion in profiling.sampling - #155592
Closed
AbhinavMir wants to merge 3 commits into
Closed
gh-155591: Fix flame graph sample-time conversion in profiling.sampling#155592AbhinavMir wants to merge 3 commits into
AbhinavMir wants to merge 3 commits into
Conversation
…sampling The flame graph tooltips and status bar divided node values by 1000 and labelled the result as milliseconds. Node values are sample counts, so the displayed times were wrong by a factor of the sampling interval (1000x at the default 1 kHz rate). Convert sample counts using the sampling interval instead, and always record that interval in the exported flamegraph data.
|
All commit authors signed the Contributor License Agreement. |
edvilme
reviewed
Aug 11, 2026
Co-authored-by: Eduardo Villalpando Mello <[email protected]>
Co-authored-by: Eduardo Villalpando Mello <[email protected]>
Member
|
Thanks @AbhinavMir for taking the time to prepare this fix. Since #155591 has been closed as a duplicate of #154059, and #154036 is already addressing the same problem, I’m closing this PR so the discussion and implementation can remain consolidated there. Thank you again for contributing! |
Author
|
All good @pablogsal - thanks for reviewing and updating! I just thought I was being quick haha |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate fix for #155591.
profiling.samplingflame graph displays sampled function times 1000x too small #155591