Skip to content

Proxy /up to marketing-web - #22438

Merged
cnunciato merged 1 commit into
masterfrom
jeffmerrick/up-proxy-marketing-web
Oct 23, 2026
Merged

cnunciato merged 1 commit into
masterfrom
jeffmerrick/up-proxy-marketing-web

Conversation

@jeffmerrick

@jeffmerrick jeffmerrick commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Proxies /up, /up/ and /up/* to marketing-web, which serves the new getting-started wizard that's being A/B tested against /docs/get-started/. It follows the same pattern as /pricing in #22175.

  • Exact paths are used because /up* would also take the /updateplans/ alias (and any future /upgrade or /updates page) off S3.
  • Until marketing-web deploys jeffmerrick/get-started-wizard, /up/ 404s through the proxy. Nothing links there yet except the Dev Center, which ships on that same branch, so either merge order works.

New behaviors in infrastructure/index.ts:

// Exact paths: /up* would also take the /updateplans/ alias off S3.
...["/up", "/up/", "/up/*"].map((pathPattern) => ({
    ...baseCacheBehavior,
    targetOriginId: marketingCDN,
    pathPattern,
    cachePolicyId: thirtyMinuteCachePolicy.id,
    originRequestPolicyId: allViewerExceptHostHeaderId,
})),

Both path lists in invalidate-dev-cache.yml (workflow_dispatch default and PATHS fallback):

/dev /dev/ /dev/* /assets /assets/ /assets/* /community /community/ /community.md /community/puluminaries* /pricing /pricing/ /pricing.md /up /up/ /up/*

I have a follow-up PR planned that moves every marketing-web path into one list that index.ts and invalidate-dev-cache.yml both read, so adding a page stops meaning matching edits in several places.

Part of MA-810.

🤖 Generated with Claude Code

Serves the getting-started wizard from marketing-web at /up, /up/ and /up/*,
and flushes those paths when marketing-web deploys.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Sentinel — merge gate status

All gates green — nothing is blocking this merge.

Gate What it needs
✅ G1 review-ran Nothing to do: review current at 2e72b7552.
✅ G2 findings-answered Nothing to do: every finding answered.
✅ G3 right-approver Nothing to do: approved by CamSoper, who has write access.
✅ G4 infra-evidence Nothing to do: staging status green at 2e72b7552 (by github-actions[bot]).
➖ G5 oversized-ack Doesn't apply to this PR: not oversized.

Evaluated at head 2e72b7552.


Need help, or think a gate got it wrong? Ask in #docs on Slack.

@pulumi-bot

Copy link
Copy Markdown
Collaborator

@jeffmerrick
jeffmerrick marked this pull request as ready for review October 22, 2026 21:09
@jeffmerrick
jeffmerrick requested a review from cnunciato October 22, 2026 21:09
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config labels Oct 22, 2026
@pulumi-bot
pulumi-bot requested a review from a team October 22, 2026 21:10
@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Oct 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Reviewer's guide v1 — not for the author

Tip

Check the ⚠️ items, then approve. Your approval covers only those; links, shortcodes, metadata, and verified claims were checked by machine (receipts on the evidence page). Code samples are read, not compiled.

PR author: nothing here is yours. Your to-do list is the "Author action guide" comment.

Review requested from: @pulumi/docs-tools — an approval from anyone with write access satisfies the merge gate.

Note

What this PR changes:

  • infrastructure/index.ts: new CloudFront behaviors send /up, /up/, and /up/* to the marketing-web origin.
  • invalidate-dev-cache.yml: the /up paths join the default invalidation list, in both places it appears.
  • AGENTS.md and BUILD-AND-DEPLOY.md: document /up as a page served from marketing-web.

The PR would break things if the proxy pattern were too broad (/up* would take /updateplans/ and /uploads/* off S3) or if the invalidation list went out of sync with the behaviors. The review ran an infra read of the diff, a check that the pattern is exact and agrees with the workflow and docs, and a check that no Hugo content/up page is being shadowed.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH

⚠️ Check these before approving

Nothing needs a human eye beyond the rubber-stamp list below.

✅ What you can rubber-stamp

  • Facts: 3 factual claims checked — 3 verified clean.
  • Mechanics: no internal links added.
  • Style: 0 advisory suggestions left with the author; never blocking.

Pre-existing issues in touched files: 0 — details on the evidence page.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-10-22T21:11:38Z · head commit 2e72b75


For the reviewer: something look wrong? Comment /update-review <your point> and the review re-checks with your input.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Author action guide v1 — nothing blocks merge

Note

Nothing here needs an answer from you. A human reviewer still approves the merge.

This PR routes /up, /up/, and /up/* to the marketing-web CloudFront origin and adds those paths to the cache-invalidation defaults and the docs; the review checked the CloudFront behaviors, the workflow defaults, and the AGENTS.md and BUILD-AND-DEPLOY.md text against each other.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-10-22T21:11:38Z · head commit 2e72b75


Please don't edit or delete this comment; it's the review's record.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Oct 22, 2026

@CamSoper CamSoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@cnunciato
cnunciato merged commit 99b00a1 into master Oct 23, 2026
38 checks passed
@cnunciato
cnunciato deleted the jeffmerrick/up-proxy-marketing-web branch October 23, 2026 06:25

This branch was successfully deployed

2 active deployments
production — 2e72b755 Deployed Oct 23, 2026 by cnunciato via Record review outcome #14903
testing — 2e72b755 Deployed Oct 23, 2026 by cnunciato via Do cleanup #14903
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants