Skip to content

Keep marketing-web proxied paths in one list - #22464

Open
jeffmerrick wants to merge 3 commits into
masterfrom
jeffmerrick/marketing-web-paths
Open

jeffmerrick wants to merge 3 commits into
masterfrom
jeffmerrick/marketing-web-paths

Conversation

@jeffmerrick

@jeffmerrick jeffmerrick commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Proposed changes

Moves the paths proxied to pulumi/marketing-web into one list, infrastructure/marketingWebPaths.ts, which both the CloudFront behaviors and the cache-flush workflow read. The workflow also runs with noglob now, since bash was expanding /dev/* into the runner's device files and Dev Center subpages were never flushed.

  • The distribution keeps the same 12 behaviors in the same order, so the preview should show no CDN changes.
  • The workflow reads the new marketingWebPaths stack output, which doesn't exist until this deploys. A marketing-web deploy in between fails the flush, and re-running it after the deploy fixes it.
  • invalidate-dev-cache.yml is renamed to invalidate-marketing-web-cache.yml. The repository_dispatch type is still dev-deployed, which is what marketing-web sends, so its deploys still trigger the workflow.

Unreleased product version (optional)

None.

Related issues (optional)

Follow-up to #22438. infra/www/index.ts and apps/www/docs/dev.md in pulumi/marketing-web still name the old workflow file.

Validation

Deployed 646673aa to pulumi-test.io (stack update v6444, marketingWebPaths output present).

  • 34 URLs return the same status, origin, and redirect target on pulumi-test.io as on www.pulumi.com: the proxied pages, plus the S3 pages and redirects the wildcards could catch (/community/team/*, /community/community-engineering/*, /pricing/open-source-free-tier/, /updateplans/, /puluminaries/, /learn/, /tutorials/, /templates/).
  • /community.md, /pricing.md, /dev/search-index.json, and /assets/favicon.svg are byte-identical to production.
  • The workflow's pulumi stack output marketingWebPaths --json | jq line, run with noglob against the testing stack, yields the 12 paths unexpanded.
  • The create-invalidation call itself is untested, since the renamed workflow can't be dispatched until it's on master and runs against production.

🤖 Generated with Claude Code

Move the paths www.pulumi.com proxies to pulumi/marketing-web into
infrastructure/marketingWebPaths.ts. index.ts maps it to cache behaviors
and exports it as a stack output, which the cache-flush workflow now reads
in place of its two hardcoded lists.

The workflow passed $PATHS unquoted, so bash globbed /dev/* against the
runner's device files and Dev Center subpages were never flushed; set
noglob. Rename it to invalidate-marketing-web-cache.yml, since it covers
/community, /pricing, and /up too. The dev-deployed dispatch type is
unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Sentinel — merge gate status

All gates green — nothing is blocking this merge.

Gate What it needs
✅ G1 review-ran Nothing to do: review current at 02b6e81d9.
✅ G2 findings-answered Nothing to do: every finding answered.
✅ G3 right-approver Nothing to do: approved by CamSoper, who has write access.
✅ G4 infra-evidence Nothing to do: staging status green at 02b6e81d9 (by github-actions[bot]).
➖ G5 oversized-ack Doesn't apply to this PR: not oversized.

Evaluated at head 02b6e81d9.


Need help, or think a gate got it wrong? Ask in #docs on Slack.

@pulumi-bot

pulumi-bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

The unquoted "default: " inside it made the workflow file invalid YAML.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@jeffmerrick
jeffmerrick marked this pull request as ready for review October 23, 2026 14:44
@github-actions github-actions Bot added review:triaging Claude Triage is currently classifying the PR domain:infra PR touches workflows, scripts, infra, Makefile, or build config labels Oct 23, 2026
@pulumi-bot
pulumi-bot requested a review from a team October 23, 2026 14:45
@github-actions github-actions Bot added review:in-progress Claude review is currently running and removed review:triaging Claude Triage is currently classifying the PR labels Oct 23, 2026
@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer's guide v2 — not for the author

Tip

Check the ⚠️ items, then approve. Your approval covers only those; links, shortcodes, metadata, and verified claims were checked by machine (receipts on the evidence page). Code samples are read, not compiled.

PR author: nothing here is yours. Your to-do list is the "Author action guide" comment.

Review requested from: @pulumi/docs-tools — an approval from anyone with write access satisfies the merge gate.

Note

What this PR changes:

  • infrastructure/marketingWebPaths.ts: new file that holds the single list of paths proxied to marketing-web.
  • infrastructure/index.ts: builds the CloudFront behaviors from that list and exports it as the marketingWebPaths stack output.
  • invalidate-marketing-web-cache.yml: reads the paths from the stack output instead of a hardcoded list.
  • AGENTS.md / BUILD-AND-DEPLOY.md: point at the new file.

A wrong path list or a broken stack-output lookup would route pulumi.com pages to the wrong origin, or leave a stale CloudFront cache after marketing-web deploys. The fact-check and infra-domain passes ran. The workflow exits with an error if the stack output is empty, and that output only exists once this infra change has deployed.

Review confidence:

Dimension Level Notes
mechanics MEDIUM CloudFront behavior order and the stack output were read but not deployed; no staging evidence seen.
facts MEDIUM Couldn't verify whether /up is still being A/B tested (F1).

⚠️ Check these before approving

Nothing needs a human eye beyond the rubber-stamp list below.

✅ What you can rubber-stamp

  • Facts: 4 factual claims checked — 3 verified clean, 1 settled — see the evidence page.
  • Mechanics: no internal links added.
  • Style: 0 advisory suggestions left with the author; never blocking.

Pre-existing issues in touched files: 0 — details on the evidence page.

Full evidence: verification trail, investigation log, review history.

Review v2 · updated 2026-10-23T15:26:27Z · head commit 02b6e81


For the reviewer: something look wrong? Comment /update-review <your point> and the review re-checks with your input.

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Author action guide v2 — nothing blocks merge

Important

You = the PR author. Answer every item below before this PR can merge.

To answer: push a fix, or reply /update-review F1: <what you fixed, why it's wrong, or "accepting as-is — why">. A reply without /update-review at the start of a line doesn't count. Examples: How to answer at the bottom.

This PR moves the marketing-web proxied paths into infrastructure/marketingWebPaths.ts, exports them as a stack output that the cache-invalidation workflow reads, and updates AGENTS.md and BUILD-AND-DEPLOY.md to match. The review checked the factual claims in the doc changes and the workflow/infra wiring.

✅ Resolved since last review

1 resolved item — click to expand
ID Where Finding
F1 AGENTS.md L103 "- /up: the getting-started wizard, which is being A/B tested against…" — verdict: unverifiable. Nothing in this repo or in public sources confirms whether /up is still under an A/B test. — ✅ fixed in 02b6e81

Full evidence: verification trail, investigation log, review history.

Review v2 · updated 2026-10-23T15:26:27Z · head commit 02b6e81


Please don't edit or delete this comment; it's the review's record.

@github-actions github-actions Bot added review:outstanding-issues Claude review completed; outstanding has author-actionable findings and removed review:in-progress Claude review is currently running labels Oct 23, 2026
Drop the /up A/B-test and noindex note and the inventory of pricing
page parts; keep where each page is built and what stays in this repo.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
@jeffmerrick

Copy link
Copy Markdown
Contributor Author

/update-review I pushed a fix for F1

@github-actions github-actions Bot added review:stale New commits since last Claude review; refresh on next ready-transition or @claude mention and removed review:outstanding-issues Claude review completed; outstanding has author-actionable findings labels Oct 23, 2026
@github-actions github-actions Bot added review:in-progress Claude review is currently running review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:stale New commits since last Claude review; refresh on next ready-transition or @claude mention review:in-progress Claude review is currently running labels Oct 23, 2026

@CamSoper CamSoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This branch was successfully deployed

1 active deployment
testing — 02b6e81d Deployed Oct 23, 2026 by github-actions[bot] via Install deps and build site #3312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain:infra PR touches workflows, scripts, infra, Makefile, or build config review:no-blockers Claude review completed cleanly; outstanding is empty

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants