Repository navigation
Keep marketing-web proxied paths in one list - #22464
jeffmerrick wants to merge 3 commits into
Conversation
Move the paths www.pulumi.com proxies to pulumi/marketing-web into infrastructure/marketingWebPaths.ts. index.ts maps it to cache behaviors and exports it as a stack output, which the cache-flush workflow now reads in place of its two hardcoded lists. The workflow passed $PATHS unquoted, so bash globbed /dev/* against the runner's device files and Dev Center subpages were never flushed; set noglob. Rename it to invalidate-marketing-web-cache.yml, since it covers /community, /pricing, and /up too. The dev-deployed dispatch type is unchanged. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Sentinel — merge gate statusAll gates green — nothing is blocking this merge.
Evaluated at head Need help, or think a gate got it wrong? Ask in |
|
Your site preview for commit 02b6e81 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-22464-02b6e81d.s3-website.us-west-2.amazonaws.com |
The unquoted "default: " inside it made the workflow file invalid YAML. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Reviewer's guide v2 — not for the authorTip Check the PR author: nothing here is yours. Your to-do list is the "Author action guide" comment. Review requested from: @pulumi/docs-tools — an approval from anyone with write access satisfies the merge gate. Note What this PR changes:
A wrong path list or a broken stack-output lookup would route pulumi.com pages to the wrong origin, or leave a stale CloudFront cache after marketing-web deploys. The fact-check and infra-domain passes ran. The workflow exits with an error if the stack output is empty, and that output only exists once this infra change has deployed. Review confidence:
|
Author action guide v2 — nothing blocks mergeImportant You = the PR author. Answer every item below before this PR can merge. To answer: push a fix, or reply This PR moves the marketing-web proxied paths into ✅ Resolved since last review1 resolved item — click to expand
Full evidence: verification trail, investigation log, review history. Review v2 · updated 2026-10-23T15:26:27Z · head commit 02b6e81 Please don't edit or delete this comment; it's the review's record. |
Drop the /up A/B-test and noindex note and the inventory of pricing page parts; keep where each page is built and what stays in this repo. Co-Authored-By: Claude Fable 5.1 <[email protected]>
|
/update-review I pushed a fix for F1 |
Proposed changes
Moves the paths proxied to pulumi/marketing-web into one list,
infrastructure/marketingWebPaths.ts, which both the CloudFront behaviors and the cache-flush workflow read. The workflow also runs withnoglobnow, since bash was expanding/dev/*into the runner's device files and Dev Center subpages were never flushed.marketingWebPathsstack output, which doesn't exist until this deploys. A marketing-web deploy in between fails the flush, and re-running it after the deploy fixes it.invalidate-dev-cache.ymlis renamed toinvalidate-marketing-web-cache.yml. Therepository_dispatchtype is stilldev-deployed, which is what marketing-web sends, so its deploys still trigger the workflow.Unreleased product version (optional)
None.
Related issues (optional)
Follow-up to #22438.
infra/www/index.tsandapps/www/docs/dev.mdin pulumi/marketing-web still name the old workflow file.Validation
Deployed
646673aato pulumi-test.io (stack update v6444,marketingWebPathsoutput present)./community/team/*,/community/community-engineering/*,/pricing/open-source-free-tier/,/updateplans/,/puluminaries/,/learn/,/tutorials/,/templates/)./community.md,/pricing.md,/dev/search-index.json, and/assets/favicon.svgare byte-identical to production.pulumi stack output marketingWebPaths --json | jqline, run withnoglobagainst the testing stack, yields the 12 paths unexpanded.create-invalidationcall itself is untested, since the renamed workflow can't be dispatched until it's on master and runs against production.🤖 Generated with Claude Code