Repository navigation
Publish reviews started by #new-review and redispatch again - #22201
Conversation
#22182 put an autofire-gate job in front of claude-review. That job is skipped on workflow_dispatch, and a skipped ancestor fails the implicit success() check on every job below it, so publish (and redispatch) were skipped on every dispatched run: #new-review, the CLI dispatcher, and the freshness redispatch all reviewed the PR and published nothing, leaving review:in-progress on the PR. claude-review already used !cancelled() for this; publish and redispatch now do too, with an explicit result check so they still only run after a successful upstream job. A test now asserts every job downstream of autofire-gate carries a status function. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
github-actions
Bot
added
the
review:triaging
Sentinel — merge gate status (preview)Warning
|
| Gate | What it needs | |
|---|---|---|
| 🔴 | G1 review-ran | No current review for 31474bc19 — comment @claude <what changed> #update-review to refresh it, or @claude #new-review for a fresh one. |
| ➖ | G2 findings-answered | Doesn't apply to this PR: no review present — see G1. |
| 🔴 | G3 right-approver | Needs an approval from anyone with write access to this repo — no qualifying human approval at this head (bot approvals count only on the automated lanes bot_approvers lists). |
| ➖ | G4 infra-evidence | Doesn't apply to this PR: no changed path affects the deploy. |
| ➖ | G5 oversized-ack | Doesn't apply to this PR: not oversized. |
Break glass: a member of a routing team (.github/review-routing.yml teams:) can apply review:waived, which is logged.
Evaluated at head 31474bc19.
github-actions
Bot
added
the
domain:infra
github-actions
Bot
removed
the
review:triaging
|
Your site preview for commit 31474bc is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-22201-31474bc1.s3-website.us-west-2.amazonaws.com |
Since #22182, a review started by
@claude #new-review, the CLI dispatcher, or the freshness redispatch runs to completion and then publishes nothing, leaving the PR stuck onreview:in-progress.#22182 put an
autofire-gatejob in front ofclaude-review. It's skipped onworkflow_dispatch, and a skipped ancestor fails the implicitsuccess()check on every job below it.claude-reviewalready guards against that with!cancelled();publishandredispatchdidn't, so both were skipped.claude-reviewsuccess →publishsuccess.claude-reviewsuccess →publishskipped.Changes:
.github/workflows/claude-code-review.yml:publishandredispatchnow start with!cancelled()plus an explicitneeds.<job>.result == 'success', so they still only run after a successful upstream job.scripts/review-v3/test_handoff_guard.py: updates the pinnedredispatchcondition and adds a test that every job downstream ofautofire-gatecarries a status function.make test-review-pipelinepasses. After merge, #21210, #22163, and #22195 need their#new-reviewre-run.🤖 Generated with Claude Code