Repository navigation
Content review: content/docs/esc/languages-sdks/dotnet.md - #22163
Conversation
Automated existing-content review. Co-Authored-By: Claude <[email protected]>
Sentinel — merge gate status (preview)Warning
|
| Gate | What it needs | |
|---|---|---|
| ✅ | G1 review-ran | Nothing to do: review current at 5ba0e2dcc. |
| ✅ | G2 findings-answered | Nothing to do: every finding answered. |
| ✅ | G3 right-approver | Nothing to do: approved by CamSoper, who has write access. |
| ➖ | G4 infra-evidence | Doesn't apply to this PR: no changed path affects the deploy. |
| ➖ | G5 oversized-ack | Doesn't apply to this PR: not oversized. |
Evaluated at head 5ba0e2dcc.
|
Your site preview for commit 5ba0e2d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-22163-5ba0e2dc.s3-website.us-west-2.amazonaws.com Changed pages: |
jkodroff
left a comment
There was a problem hiding this comment.
See comment - I'm not sure what other CLI credentials exist, but I could be mistaken.
|
@claude no review ran on this PR #new-review Generated by Claude Code |
"Pulumi CLI credentials" was ambiguous, since the CLI also honors PULUMI_ACCESS_TOKEN. Name the on-disk `pulumi login` credentials the 0.13.x fallback read, and pin the change to v0.14.0 to match the Python and JavaScript SDK pages. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01MxA1mkP3utaJ3Wt3PKvs6h
|
@claude the last #new-review never published (fixed in #22201) #new-review Generated by Claude Code |
Reviewer's guide v1 — not for the authorTip Check the PR author: nothing here is yours. Your to-do list is the "Author action guide" comment. Approval needed from: @pulumi/docs-guild — any member's approval satisfies the merge gate. Note What this PR changes:
A wrong version or credential source would leave .NET readers unable to authenticate after upgrading. Fact-check and frontmatter/mechanics passes ran; the sibling Python and JavaScript SDK pages were not separately re-read. Review confidence:
|
Author action guide v1 — nothing blocks mergeNote Nothing here needs an answer. Automation opened this PR; a human reviewer still approves the merge. This automated content-review PR clarifies that Full evidence: verification trail, investigation log, review history. Review v1 · updated 2026-10-08T22:15:05Z · head commit 5ba0e2d Please don't edit or delete this comment; it's the review's record. |
Important
This PR requires a human review decision — auto-merge is NOT armed. Its fixes include judgment-class changes (claim corrections, structural repairs), so approving does not merge it by itself: the PR-review sweep arms auto-merge only after its own gates pass, or a human merges manually.
Why this page
content/docs/esc/languages-sdks/dotnet.md→ /docs/esc/languages-sdks/dotnet/no_retire: false)CLICKSTREAM.FCT_PAGEVIEWS)attempts: 0)This section is composed deterministically from the selection queue; do not edit it.
Fixes applied
EscClient.CreateDefault()first looks for thePULUMI_ACCESS_TOKENenvironment variable, and if it is not present, falls back to Pulumi CLI credentials on t…CreateDefault()now documented as readingPULUMI_ACCESS_TOKENonly and throwingInvalidOperationExceptionwhen it isn't set, with no CLI-credential fallback. MatchesEscAuth.GetDefaultAccessToken()on the default branch and at the releasedv0.14.0tag (the fallback was removed from all SDKs in pulumi/esc-sdk#137); wording mirrors the already-corrected Go sibling page.PULUMI_ACCESS_TOKENis not set,EscClient.CreateDefault()falls back to the Pulumi CLI credentials on the machine if the user has logged in using the Pu…Findings not applied
sdk-dotnet-exampleenvironment from the Manage environment example, so run that example first. Creating …)### Initializing ESC SDK clientto an H2 (## Initialize the ESC SDK client) so it sits next to## Install the SDK packageinstead of under it.)The items above are banked for the automated glow-up lane, which executes a page's accumulated deferrals under human review — or run
/glow-up content/docs/esc/languages-sdks/dotnet.mdto work them now.Screenshot check
No images. The page source references no screenshots, diagrams, or other content images (only the generic shared
meta_imagecard, if any), so there is nothing to verify. (Determined from the source; the screenshot pass was skipped.)Rendered content
Ran
make buildand checkedpublic/docs/esc/languages-sdks/dotnet/index.htmlandindex.md. The only render-time residue is theesc-sdk-config-notecallout ("Use the ESC SDK to retrieve environment values from your application workloads at runtime ... use config instead of the SDK"), which renders in both views; its link target/docs/esc/guides/pulumi-iac/exists. No checkable factual claims in the residue are wrong, so no shared-source fix was applied (the shortcode is used on 5 pages). The L47 correction renders as expected in both views.Verification
make lint: ✅make lintre-verified by the workflow on146b6f9.verified-claims.json: 22 verdict(s); 2 contradicted/mismatch, 0 unverifiable.vale-findings.json: 1 finding(s).readthrough-findings.json: ran=True, 3 finding(s).frontmatter-validation.json: 1 file(s); 0 alias collision(s)