Skip to content

Content review: content/docs/esc/languages-sdks/dotnet.md - #22163

Merged
CamSoper merged 2 commits into
masterfrom
content-review/docs-esc-languages-sdks-dotnet
Oct 8, 2026
Merged

CamSoper merged 2 commits into
masterfrom
content-review/docs-esc-languages-sdks-dotnet

Conversation

@pulumi-bot

@pulumi-bot pulumi-bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Important

This PR requires a human review decision — auto-merge is NOT armed. Its fixes include judgment-class changes (claim corrections, structural repairs), so approving does not merge it by itself: the PR-review sweep arms auto-merge only after its own gates pass, or a human merges manually.

Why this page

  • Page: content/docs/esc/languages-sdks/dotnet.md → /docs/esc/languages-sdks/dotnet/
  • Lane: priority
  • Strategic tier: 2 (no_retire: false)
  • Traffic: 100 monthly visits (period 2026-04-05 to 2026-10-05; source CLICKSTREAM.FCT_PAGEVIEWS)
  • Search: 3 impressions, 0.00% CTR, corpus median 0.72%, period 2026-04-05 to 2026-10-05
  • Last reviewed: never (attempts: 0)
  • Selection score: 39.8326

This section is composed deterministically from the selection queue; do not edit it.

Fixes applied

Claim / finding Authoritative source Correction
Claim (c8, L47): EscClient.CreateDefault() first looks for the PULUMI_ACCESS_TOKEN environment variable, and if it is not present, falls back to Pulumi CLI credentials on t… gh api repos/pulumi/esc-sdk/contents/sdk/csharp/Pulumi.Esc.Sdk/EscAuth.cs; repos/pulumi/esc-sdk/contents/sdk/csharp/Pulumi.Esc.Sdk/EscClient.cs Replaced the L47 sentence: CreateDefault() now documented as reading PULUMI_ACCESS_TOKEN only and throwing InvalidOperationException when it isn't set, with no CLI-credential fallback. Matches EscAuth.GetDefaultAccessToken() on the default branch and at the released v0.14.0 tag (the fallback was removed from all SDKs in pulumi/esc-sdk#137); wording mirrors the already-corrected Go sibling page.
Claim (c9, L47): If PULUMI_ACCESS_TOKEN is not set, EscClient.CreateDefault() falls back to the Pulumi CLI credentials on the machine if the user has logged in using the Pu… gh api repos/pulumi/esc-sdk/contents/sdk/csharp/Pulumi.Esc.Sdk/EscAuth.cs (L21-31); repos/pulumi/esc-sdk/contents/sdk/csharp/Pulumi.Esc.Sdk/EscClient.cs (L109-120) Same L47 sentence as c8; resolved by the single edit above.

Findings not applied

  • Vale wordiness (L59): 'All of' is too wordy. — Style nag without a deterministic fix; rewording is an editorial call. (context: 'All of' is too wordy.)
  • Readthrough missing-step (L101-121): "Expected at least 2 revisions for environment {projName}/{envName}" — Readthrough findings are banked for the glow-up lane; adding a dependency note between examples is a structural change for human review. (context: At L103, add a sentence saying this example uses the sdk-dotnet-example environment from the Manage environment example, so run that example first. Creating …)
  • Readthrough orphaned-structure (L33-37): "### Initializing ESC SDK client" — Readthrough findings are banked for the glow-up lane; promoting the heading changes page structure (siblings share the same outline). (context: Change ### Initializing ESC SDK client to an H2 (## Initialize the ESC SDK client) so it sits next to ## Install the SDK package instead of under it.)
  • Readthrough self-redundancy (L16): "The SDK supports C#, F#, and Visual Basic." — Readthrough findings are banked for the glow-up lane; deleting the repeated sentence on L31 is an editorial call. (context: Delete the duplicate sentence 'The SDK supports C#, F#, and Visual Basic.' from L31. L16 already says this.)

The items above are banked for the automated glow-up lane, which executes a page's accumulated deferrals under human review — or run /glow-up content/docs/esc/languages-sdks/dotnet.md to work them now.

Screenshot check

No images. The page source references no screenshots, diagrams, or other content images (only the generic shared meta_image card, if any), so there is nothing to verify. (Determined from the source; the screenshot pass was skipped.)

Rendered content

Ran make build and checked public/docs/esc/languages-sdks/dotnet/index.html and index.md. The only render-time residue is the esc-sdk-config-note callout ("Use the ESC SDK to retrieve environment values from your application workloads at runtime ... use config instead of the SDK"), which renders in both views; its link target /docs/esc/guides/pulumi-iac/ exists. No checkable factual claims in the residue are wrong, so no shared-source fix was applied (the shortcode is used on 5 pages). The L47 correction renders as expected in both views.

Verification

  • make lint: ✅ make lint re-verified by the workflow on 146b6f9
  • Pre-step artifacts:
    • .verified-claims.json: 22 verdict(s); 2 contradicted/mismatch, 0 unverifiable
    • .vale-findings.json: 1 finding(s)
    • .readthrough-findings.json: ran=True, 3 finding(s)
    • .frontmatter-validation.json: 1 file(s); 0 alias collision(s)

Automated existing-content review.

Co-Authored-By: Claude <[email protected]>
@pulumi-bot pulumi-bot added the content-review/judgment Content-review PR containing judgment-class fixes (needs a human eye) label Oct 7, 2026
@github-actions github-actions Bot added the review:triaging Claude Triage is currently classifying the PR label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Sentinel — merge gate status (preview)

Warning

⚠️ Preview mode — this check is NOT blocking your merge

The Sentinel is in preview (report-only) mode: its check-run concludes neutral whatever the gates below say, so nothing here gates this PR. The rows are informational and safe to ignore for now. It would have concluded success.

This will be enforced in the near future. Once it is, every row below has to be green before this PR can merge. The rows are the sign-offs a merge needs — some yours, some a reviewer's or a deploy's. Tell us in #docs if one looks wrong.

All gates green — nothing would block this merge.

Gate What it needs
✅ G1 review-ran Nothing to do: review current at 5ba0e2dcc.
✅ G2 findings-answered Nothing to do: every finding answered.
✅ G3 right-approver Nothing to do: approved by CamSoper, who has write access.
➖ G4 infra-evidence Doesn't apply to this PR: no changed path affects the deploy.
➖ G5 oversized-ack Doesn't apply to this PR: not oversized.

Evaluated at head 5ba0e2dcc.

@github-actions github-actions Bot added domain:docs PR touches technical docs review:trivial Tiny prose-only change; skips Claude review labels Oct 7, 2026
@pulumi-bot
pulumi-bot requested a review from a team October 7, 2026 14:27
@github-actions github-actions Bot removed the review:triaging Claude Triage is currently classifying the PR label Oct 7, 2026
@pulumi-bot

pulumi-bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator Author

@jkodroff jkodroff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment - I'm not sure what other CLI credentials exist, but I could be mistaken.

@CamSoper

CamSoper commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@claude no review ran on this PR #new-review


Generated by Claude Code

@github-actions github-actions Bot added the review:in-progress Claude review is currently running label Oct 8, 2026
"Pulumi CLI credentials" was ambiguous, since the CLI also honors
PULUMI_ACCESS_TOKEN. Name the on-disk `pulumi login` credentials the
0.13.x fallback read, and pin the change to v0.14.0 to match the
Python and JavaScript SDK pages.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Claude-Session: https://claude.ai/code/session_01MxA1mkP3utaJ3Wt3PKvs6h
@CamSoper

CamSoper commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@claude the last #new-review never published (fixed in #22201) #new-review


Generated by Claude Code

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Reviewer's guide v1 — not for the author

Tip

Check the ⚠️ items, then approve. Your approval covers only those; links, shortcodes, metadata, and verified claims were checked by machine (receipts on the evidence page). Code samples are read, not compiled.

PR author: nothing here is yours. Your to-do list is the "Author action guide" comment.

Approval needed from: @pulumi/docs-guild — any member's approval satisfies the merge gate.

Note

What this PR changes:

  • .NET ESC SDK auth note: names the on-disk pulumi login credentials as the dropped fallback and pins the change to v0.14.0.

A wrong version or credential source would leave .NET readers unable to authenticate after upgrading. Fact-check and frontmatter/mechanics passes ran; the sibling Python and JavaScript SDK pages were not separately re-read.

Review confidence:

Dimension Level Notes
mechanics HIGH
facts HIGH
cross-sibling consistency MEDIUM Sibling SDK pages not re-read this run

⚠️ Check these before approving

Nothing needs a human eye beyond the rubber-stamp list below.

✅ What you can rubber-stamp

  • Facts: 1 factual claim checked — 1 verified clean.
  • Mechanics: frontmatter sweep ran; no internal links added.
  • Style: 0 advisory suggestions left with the author; never blocking.

Pre-existing issues in touched files: 0 — details on the evidence page.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-10-08T22:15:05Z · head commit 5ba0e2d


For the reviewer: something look wrong? Comment @claude <your point> #update-review and the review re-checks with your input.

@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Author action guide v1 — nothing blocks merge

Note

Nothing here needs an answer. Automation opened this PR; a human reviewer still approves the merge.

This automated content-review PR clarifies that Pulumi.Esc.Sdk v0.14.0 no longer reads the on-disk pulumi login credentials; the review checked the version claim and the page's mechanics.

Full evidence: verification trail, investigation log, review history.

Review v1 · updated 2026-10-08T22:15:05Z · head commit 5ba0e2d


Please don't edit or delete this comment; it's the review's record.

@github-actions github-actions Bot added review:no-blockers Claude review completed cleanly; outstanding is empty and removed review:in-progress Claude review is currently running labels Oct 8, 2026

@CamSoper CamSoper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@CamSoper
CamSoper merged commit 8fb5f2f into master Oct 8, 2026
28 checks passed
@CamSoper
CamSoper deleted the content-review/docs-esc-languages-sdks-dotnet branch October 8, 2026 22:41

This branch was successfully deployed

1 active deployment
testing — 5ba0e2dc Deployed Oct 8, 2026 by CamSoper via Do cleanup #14688
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content-review/judgment Content-review PR containing judgment-class fixes (needs a human eye) domain:docs PR touches technical docs review:no-blockers Claude review completed cleanly; outstanding is empty review:trivial Tiny prose-only change; skips Claude review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants