Repository navigation
Audit fixes (2026-10): literal pathspecs, export comments, loopback bind, special-char paths #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
022592b
fix(git): pass pathspecs verbatim after -- so special-char paths keep…
praxstack 4529da8
fix(export): include reviewer comments in unified review [AVCR-002]
praxstack bd3ec1d
fix(server): bind 127.0.0.1 by default, HOST env for Docker, publish …
praxstack 91b58b6
fix(git): match paths literally and reject magic pathspecs [review: M…
praxstack a6ad3e9
fix(export): match line comments to their exact file in both generato…
praxstack ec4d1da
fix(web): allow [ ] ( ) { } $ in reviewed file paths [review: MINOR-2]
praxstack 0ecb0c6
fix(docker): healthchecks probe 127.0.0.1 instead of localhost [revie…
praxstack 79edb97
fix(export): make line-comment ids unique per file [review: codex-sec…
praxstack 149edaf
fix(export): read only own file-comment keys [codex: Check ownership …
praxstack 99e44be
fix(server): show and open the configured bind address [codex: Open t…
praxstack cdcdbaa
docs(audit): add 2026-10 audit reports
praxstack File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # FIXES - ai-visual-code-review (branch fix/audit-2026-10) | ||
|
|
||
| P0/P1 kept findings: AVCR-001, AVCR-002, AVCR-005. (AVCR-017/018/019/029 are P1 but verdict duplicate, so skipped; 018 and 029 are merged into 005.) | ||
| Safe test command: 7 suites, 107/107 pass (not full npm test; worktree clean afterwards apart from the commits). | ||
|
|
||
| | id | status | commit | evidence | remains | | ||
| |---|---|---|---|---| | ||
| | AVCR-001 | fixed | see git log (fix(git)) | test/git-service-paths.test.js: 3 of 4 cases fail before, 4/4 pass after | Args before `--` still use the old char filter (no caller passes any). | | ||
| | AVCR-002 | fixed | see git log (fix(export)) | test/unified-review-comments.test.js fails before, passes after | "Files processed: undefined" in the page text (SETUP 5.3) not addressed; it is client-side and outside this finding. | | ||
| | AVCR-005 | partial | see git log (fix(server)) | test/bind-host.test.js: 3 fail before, 3 pass after | Remote-access hardening beyond the loopback default is an owner decision (details kept privately by the owner). Docker still unfixed per AVCR-006 (no git in image, working_dir). Default now 127.0.0.1; HOST=0.0.0.0 set in Dockerfile/compose; compose publishes 127.0.0.1:3002. | | ||
|
|
||
| Later review and Codex follow-ups on PR #43 (literal pathspecs, exact lineId matching, special-path web view, healthcheck host, own-key comment lookup, bind-address banner) are recorded in the PR itself. | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Distinguish the final test result from the earlier count.
This line reports 7 suites and 107 tests without identifying that result as intermediate. The PR’s final validation reports 9 suites and 130 tests. Update this line or label the earlier result and add the final count. (github.com)
🧰 Tools
🪛 LanguageTool
[locale-violation] ~4-~4: In American English, ‘afterward’ is the preferred variant. ‘Afterwards’ is more commonly used in British English and other dialects.
Context: ...pass (not full npm test; worktree clean afterwards apart from the commits). | id | status...
(AFTERWARDS_US)
🤖 Prompt for AI Agents