Repository navigation
PCSM-311 Make target write concern configurable - #89
rasika-chivate wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The documentation is consistent across all configuration surfaces, and the new internal links resolve correctly.
0 open findings
What changed in this PR
Documents configurable target write concern for PCSM 1.1.0, including configuration methods, persistence, and rollback risks.
Changes:
- Documents CLI, API, and environment-variable configuration.
- Defines supported values, defaults, and recovery behavior.
- Adds operational and HA safety guidance.
| File | Description |
|---|---|
docs/install/usage.md |
Adds configuration examples and rollback guidance. |
docs/pcsm-commands.md |
Documents the new CLI flag. |
docs/install/parameters.md |
Documents the environment variable. |
docs/api.md |
Documents the /start request field. |
docs/high-availability.md |
Explains HA recovery implications. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ded targets' Co-authored-by: Copilot Autofix powered by AI <[email protected]>
…ite concern option' Co-authored-by: Copilot Autofix powered by AI <[email protected]>
|
Addressed all five manual review comments in separate commits for PCSM 1.1.0.
Validation: MkDocs build, The existing PR #87's branch and pre-splitting documentation remain untouched. Both features remain present in this combined branch. No manual feedback remains unresolved. Existing Copilot fixes were preserved; no new Copilot review was requested as part of this manual-comment pass. |

Replaces PR #88 using the branch
PCSM-311-PCSM-382-docs. The documentation content is identical to #88's latest commit. PR #87 retains its pre-splitting documentation unchanged. This branch includes both features, while the diff against #87 contains only target write concern changes.PCSM 1.1.0 lets users choose the write concern for target data writes during the initial clone and ongoing replication. This documents the three configuration methods, the default and supported values, and the recovery tradeoff when using a lower write concern. Checkpoints, HA state, and catalog changes continue to use majority.
Sources: PCSM-311, developer documentation notes, merged implementation PR #284, and its README.
The documentation release 1.1.0 comes from the ticket's Fix versions field. Jira marks that release as unreleased; this PR prepares documentation for it.
This PR depends on PR #87 and targets
PCSM-382-skip-presplit-docs. Merge #87 first, then retarget this PR tomain. The branch includes #87's changes, and the diff against that base contains only the target write concern documentation.Placement and changed files
docs/install/usage.md: adds Start the replication > Configure target write concern, including CLI, HTTP API, and environment-variable examples, rollback warning, run persistence, and operational cross-references.docs/pcsm-commands.md: adds--target-write-concernto thestartflags.docs/install/parameters.md: addsPCSM_TARGET_WRITE_CONCERNand makes clear that onlypcsm startconsumes it.docs/api.md: adds the string-valuedtargetWriteConcernfield toPOST /start.docs/high-availability.md: links the retained run setting and rollback risk from Checkpoint recovery.The existing pages are already in
mkdocs-base.yml. The new usage subsection appears in the rendered page TOC; no navigation file change is needed. Release notes are maintained separately in PR #85.Validation
PCSM-382-skip-presplit-docs(07daa53). Rebuilt the combined documentation successfully after stacking the branches.git diff --checkpassed.docs/about-docs.mdlinks to missingreference/contributing.md; left unchanged.Claim-to-source map
main.go(newStartCmd,resolveStartOptions,startRequest),config/config.go(bindEnvVars),cli_write_concern_test.go(TestStartTargetWriteConcernPrecedence)config/write_concern.go(ParseTargetWriteConcern),config/write_concern_test.go, CLI/API validation tests; developer comment Docs Notespcsm/pcsm.go(Checkpoint,Recover,Start)pcsm/clone/clone.go(NewClone),pcsm/repl/repl.go(NewRepl)docs/oplog-sizing.mddocs/install/usage.md, Target collections are overwritten on start warningNo claims of adjustable write concern on resume are included. PCSM-395 tracks that separate, open improvement.
Copilot's review of the original write concern changes in PR #88 reported 0 open findings. Copilot balanced review requested on this replacement PR; review is pending.