Repository navigation
fix: the headset's build rides out a short outage of GitHub's downloads - #88
Merged
Merged
Conversation
…ds: every download goes through scripts/fetch.sh, which tries server errors and dropped connections again for three minutes and names the URL and the error when it gives up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #87
An upgrade stopped three times on HTTP 500 from GitHub's release downloads: the build retried each file for only about 7 s (
curl --retry 3).scripts/fetch.sh: one download helper (POSIX sh, stage 1 has no bash). Server errors (408, 429, 5xx) and failed or dropped connections are tried again for three minutes, 5 s apart at first and up to 30 s; any other answer fails at once. Every retry and the final failure name the URL and the error. It downloads throughFILE.part, so a file is whole or absent.build-on-headset.sh(packages.sh, the Holo rootfs, the fan tool) andbuild-userspace.sh(the packages archive, the release'sSHA256SUMS, packages and databases) goes through it.tests/test_fetch.shagainst a fake server: two 500s then the file, an answer cut short, a 404, a server that stays down, a refused connection. CI runs it under dash;make testpicks it up.docs/install.mdanddocs/development.mdsay so.Checked: the new test under dash and bash, the host tests, shellcheck, the docs and private-data checks, and a real release download (with its redirect) and a missing file through the helper. Not run on the headset yet.