Repository navigation
fix: overpressure/packages 2026.11.19: symmetric field of view, lens centre offset only in the lens model - #82
Merged
Conversation
… symmetric and the lens centre offset moves only the lens model, as in stock, so neither eye's picture sits higher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins overpressure/packages
2026.11.19, for #63.pico4-monado took each eye's field of view from the lens centre offset. On SteamVR the vertical asymmetry is applied the wrong way round and moved one eye's picture several times the offset, so the earlier sign fix only moved the higher picture to the other eye. The driver now keeps the field of view symmetric and moves only the lens model, as stock does (overpressure/packages#26 has the details).
docs/xr.mdstates the directions, the symmetric field of view and the measurement.Checked here: the contracts, all host tests, the docs check and the private-data check over the history. On my headset with the fixed driver from the packages build: a 2 mm lens centre shift moves the picture 93 px up and 98 px left on the scanout (stock: 94 px), and worn only slightly; normal use felt fine. The image from this pin isn't installed yet.