Repository navigation
fix: pico4-monado keeps each eye's field of view symmetric and moves only the lens model by the lens centre offset, as stock does - #26
Merged
Conversation
…only the lens model by the lens centre offset, as stock does: SteamVR applied the vertical asymmetry swapped, which moved one eye's picture several times the offset With the field of view taken from the lens centre, 2 mm along centery moved the picture about 470 px on the panel instead of the 94 px of stock's mesh, and each sign change only moved the error to the other eye. Now 2 mm moves it 93 px up along centery and 98 px left along centerx, measured on the scanout, with stock's directions: cx = -centerx, cy = -centery in panel coordinates (y down).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For overpressure/phoenix#63.
The driver took each eye's field of view from the lens centre, so a lens centre offset made it asymmetric. On SteamVR the vertical asymmetry ends up applied the wrong way round, and it moves the picture by several times the offset itself: 2 mm along
centerymoved the right eye's picture about 470 px on the panel instead of the 94 px of stock's mesh. That's why flipping the signs only moved the higher picture to the other eye.Stock renders each eye with one symmetric frustum and moves the lens centre only in its distortion mesh. The driver now does the same:
pico4_lens_fovis symmetric, and the offset moves only the lens model, with stock's directions (cx = -centerx,cy = -centery, panel y down).Checked on the headset, measured on the scanout with the right lens centre moved 2 mm and the left eye as reference: 93 px up along
centery, 98 px left alongcenterx(stock: 94 px). Worn, the same 2 mm alongcenterynow moves the picture slightly up instead of almost out of sight, and normal use feels at least as good as before. The lens unit tests pass.