Skip to content

fix: pico4-monado keeps each eye's field of view symmetric and moves only the lens model by the lens centre offset, as stock does - #26

Merged
Xenolphthalein merged 1 commit into
mainfrom
fix/lens-symmetric-fov
Nov 19, 2026
Merged

Xenolphthalein merged 1 commit into
mainfrom
fix/lens-symmetric-fov

Conversation

@Xenolphthalein

Copy link
Copy Markdown
Contributor

For overpressure/phoenix#63.

The driver took each eye's field of view from the lens centre, so a lens centre offset made it asymmetric. On SteamVR the vertical asymmetry ends up applied the wrong way round, and it moves the picture by several times the offset itself: 2 mm along centery moved the right eye's picture about 470 px on the panel instead of the 94 px of stock's mesh. That's why flipping the signs only moved the higher picture to the other eye.

Stock renders each eye with one symmetric frustum and moves the lens centre only in its distortion mesh. The driver now does the same: pico4_lens_fov is symmetric, and the offset moves only the lens model, with stock's directions (cx = -centerx, cy = -centery, panel y down).

Checked on the headset, measured on the scanout with the right lens centre moved 2 mm and the left eye as reference: 93 px up along centery, 98 px left along centerx (stock: 94 px). Worn, the same 2 mm along centery now moves the picture slightly up instead of almost out of sight, and normal use feels at least as good as before. The lens unit tests pass.

…only the lens model by the lens centre offset, as stock does: SteamVR applied the vertical asymmetry swapped, which moved one eye's picture several times the offset

With the field of view taken from the lens centre, 2 mm along centery moved the picture about 470 px on the panel instead of the 94 px of stock's mesh, and each sign change only moved the error to the other eye. Now 2 mm moves it 93 px up along centery and 98 px left along centerx, measured on the scanout, with stock's directions: cx = -centerx, cy = -centery in panel coordinates (y down).
@Xenolphthalein
Xenolphthalein requested review from a team as code owners November 19, 2026 08:30
@Xenolphthalein
Xenolphthalein merged commit 18847e9 into main Nov 19, 2026
22 checks passed
@Xenolphthalein
Xenolphthalein deleted the fix/lens-symmetric-fov branch November 19, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant