Skip to content

OCPEDGE-2846: Bump lvm-operator build_root to rhel-9-golang-1.26-openshift-5.0 - #82660

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
qJkee:OCPEDGE-2846
Jul 30, 2026
Merged

OCPEDGE-2846: Bump lvm-operator build_root to rhel-9-golang-1.26-openshift-5.0#82660
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
qJkee:OCPEDGE-2846

Conversation

@qJkee

@qJkee qJkee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updated lvm-operator CI build roots, including nightly and nightly-upgrade configurations, from Go 1.25 to Go 1.26 on the OpenShift 5.0 build image.
  • Jira issue OCPEDGE-2846 is valid but requires target version 5.0.0 for the main branch.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@qJkee: This pull request references OCPEDGE-2846 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the ticket to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d46e2f1-9550-4fbc-acc9-82bff9d6a0fb

📥 Commits

Reviewing files that changed from the base of the PR and between 5c21298 and 8bedd40.

📒 Files selected for processing (3)
  • ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main.yaml
  • ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main__nightly-upgrade.yaml
  • ci-operator/config/openshift/lvm-operator/openshift-lvm-operator-main__nightly.yaml

Walkthrough

Updated three LVM operator CI configurations to use rhel-9-golang-1.26-openshift-5.0 instead of the Go 1.25 build root image.

Changes

LVM operator CI build image

Layer / File(s) Summary
Update build root image tags
ci-operator/config/openshift/lvm-operator/*
The main, nightly, and nightly-upgrade CI configurations now reference the Go 1.26 OpenShift 5.0 build root image.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: oliver-smakal

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: bumping the lvm-operator build_root to the Go 1.26 OpenShift 5.0 image.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML build_root tags changed; no Ginkgo test titles or test code were modified.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML build_root tags; no Ginkgo/test files were modified, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed Only CI config build_root tags changed; no Ginkgo/e2e test code or new test names were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI config YAML changed; no Ginkgo tests or cluster-topology assumptions were added, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only build_root Go image tags changed in three CI config files; no deployment manifests, controllers, affinity, node selectors, or PDBs were added.
Ote Binary Stdout Contract ✅ Passed PR only changes ci-operator YAML build_root image tags; no process-level code or stdout writes were modified, so the OTE contract isn't implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates ci-operator build_root Go image tags; no new Ginkgo e2e tests or network-using code was added.
No-Weak-Crypto ✅ Passed Only build_root image tags changed in CI YAML; no weak ciphers, custom crypto, or secret comparisons were added.
Container-Privileges ✅ Passed The three edited CI YAMLs only update the build_root image tag; scans found no privileged, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation fields.
No-Sensitive-Data-In-Logs ✅ Passed Only build_root image tag updates in CI YAML; no logging statements or new sensitive data added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026
@openshift-ci
openshift-ci Bot requested review from jeff-roche and pacevedom July 30, 2026 09:37
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@qJkee: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-lvm-operator-main-nightly-images openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-ci-index-lvm-operator-bundle openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-e2e-aws openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-e2e-aws-hypershift openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-e2e-aws-single-node openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-images openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-precommit-check openshift/lvm-operator presubmit Ci-operator config changed
pull-ci-openshift-lvm-operator-main-unit-test openshift/lvm-operator presubmit Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-mno-y-1-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-sno-arm-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-upgrade-e2e-aws-mno-y-stream-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-baremetalds-mno-dualstack-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-baremetalds-sno-dualstack-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-disc-mno-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-disc-sno-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-upgrade-e2e-aws-sno-y-stream-upgrade N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-mno-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-sno-qe-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-e2e-aws N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-e2e-aws-single-node N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-lvm-operator-main-nightly-e2e-aws-mno-arm-qe-integration-tests N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@qJkee

qJkee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-lvm-operator-main-e2e-aws pull-ci-openshift-lvm-operator-main-e2e-aws-single-node pull-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@qJkee: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/lvm-operator/main/e2e-aws-single-node 8bedd40 link unknown /pj-rehearse pull-ci-openshift-lvm-operator-main-e2e-aws-single-node
ci/rehearse/openshift/lvm-operator/main/e2e-aws-single-node-integration-tests 8bedd40 link unknown /pj-rehearse pull-ci-openshift-lvm-operator-main-e2e-aws-single-node-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kasturinarra

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2026
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasturinarra, qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qJkee

qJkee commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@qJkee: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 30, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit d838d9d into openshift:main Jul 30, 2026
15 of 17 checks passed
@qJkee
qJkee deleted the OCPEDGE-2846 branch July 30, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants