Skip to content

: No-Jira: Update oc-mirror download url in openshift-tests-private CI configs - #82407

Open
redhat-chai-bot wants to merge 3 commits into
openshift:mainfrom
redhat-chai-bot:fix/remove-oc-mirror-from-tests-private
Open

: No-Jira: Update oc-mirror download url in openshift-tests-private CI configs#82407
redhat-chai-bot wants to merge 3 commits into
openshift:mainfrom
redhat-chai-bot:fix/remove-oc-mirror-from-tests-private

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

The oc-mirror.rhel9.tar.gz file has been removed from\nmirror2.openshift.com/pub/openshift-v4/x86_64/clients/ocp-dev-preview/latest/,\ncausing the branch-ci-openshift-openshift-tests-private-main-images-images\npostsubmit to fail during image build.\n\nThis prevents the tests-private:latest image from being promoted to the\nci namespace, resulting in stale images for downstream consumers (e.g.\ncloud-provider-ibm still runs removed tests like OCP-70566).\n\nThis PR removes the two oc-mirror download/install lines from the\ndockerfile_literal RUN command in both affected CI config files:\n- openshift-openshift-tests-private-main__images.yaml\n- openshift-openshift-tests-private-release-5.0__images.yaml


@miyadav requested in Slack thread

Summary by CodeRabbit

  • Updated the openshift-tests-private CI image build definitions for both the main and release-5.0 configurations in ci-operator/config/openshift/openshift-tests-private/.
  • Bumped the builder image stream tag to rhel-9-golang-1.26-openshift-5.0 in both openshift-openshift-tests-private-main__images.yaml and openshift-openshift-tests-private-release-5.0__images.yaml.
  • Updated the dockerfile_literal RUN step to download the oc-mirror.rhel9.tar.gz tarball from ${MIRRORURL}/ocp/candidate/ (instead of the prior dev-preview path), preventing image build failures from a missing artifact and supporting promotion of the latest tests-private image to the ci namespace.
  • Kept the opm installation logic unchanged (still downloaded from ${MIRRORURL}/ocp/candidate/).
  • No Jira reference was included; the OpenShift CI bot confirmed this, and maintainers requested rehearsal and a retest.

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8660216d-445f-4939-bafe-3c167e041951

📥 Commits

Reviewing files that changed from the base of the PR and between 3bcfa49 and 0ac7671.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__images.yaml

Walkthrough

Private test image definitions update builder images to RHEL 9/Golang 1.26/OpenShift 5.0 and switch oc-mirror downloads from the dev-preview path to the candidate path.

Changes

Private test image updates

Layer / File(s) Summary
Update image bases and oc-mirror sources
ci-operator/config/openshift/openshift-tests-private/*__images.yaml
Builder image tags are upgraded, and oc-mirror downloads use ocp/candidate while retaining the existing installation steps.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: sergiordlr, memodi

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clear and matches the main change: updating the oc-mirror download URL in the openshift-tests-private CI configs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Diff only updates CI YAML build-root/image URLs; no Ginkgo It/Describe/Context/When test titles were added or changed.
Test Structure And Quality ✅ Passed PR only changes CI config YAML, not Ginkgo test code, so the test-structure checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only a ci-operator image config changed; no Ginkgo test files or new It/Describe/Context/When blocks were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No Ginkgo test code changed; the PR only updates CI image config YAML, so there are no new SNO compatibility risks to flag.
Topology-Aware Scheduling Compatibility ✅ Passed Only CI image-build YAML changed; no deployment manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed The PR only edits CI image YAML; no main/init/TestMain/suite code or stdout writes were introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only updates CI image config YAML; no new Ginkgo/e2e tests were added, so there’s no IPv4 or disconnected-network test compatibility issue to flag.
No-Weak-Crypto ✅ Passed Changed files only alter image tags and download URLs; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons found.
Container-Privileges ✅ Passed The only touched files are CI operator YAMLs; they contain no privileged/hostPID/hostNetwork/hostIPC/SYS_ADMIN/allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Changed lines only update a builder tag and mirror URL; no new sensitive data appears in logs or commands.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from memodi and sergiordlr July 24, 2026 14:40
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse auto-ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@redhat-chai-bot
redhat-chai-bot force-pushed the fix/remove-oc-mirror-from-tests-private branch from c394f0c to 32bd0f5 Compare July 24, 2026 15:06
@miyadav

miyadav commented Jul 24, 2026

Copy link
Copy Markdown
Member

/retitle: No-Jira: Update oc-mirror download url in openshift-tests-private CI configs

@openshift-ci openshift-ci Bot changed the title Remove oc-mirror download from openshift-tests-private CI configs : No-Jira: Update oc-mirror download url in openshift-tests-private CI configs Jul 24, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request explicitly references no jira issue.

Details

In response to this:

The oc-mirror.rhel9.tar.gz file has been removed from\nmirror2.openshift.com/pub/openshift-v4/x86_64/clients/ocp-dev-preview/latest/,\ncausing the branch-ci-openshift-openshift-tests-private-main-images-images\npostsubmit to fail during image build.\n\nThis prevents the tests-private:latest image from being promoted to the\nci namespace, resulting in stale images for downstream consumers (e.g.\ncloud-provider-ibm still runs removed tests like OCP-70566).\n\nThis PR removes the two oc-mirror download/install lines from the\ndockerfile_literal RUN command in both affected CI config files:\n- openshift-openshift-tests-private-main__images.yaml\n- openshift-openshift-tests-private-release-5.0__images.yaml


@miyadav requested in Slack thread

Summary by CodeRabbit

  • Updated openshift-tests-private CI image builds for the main and release-5.0 configurations.
  • Removed the unavailable oc-mirror.rhel9.tar.gz installation step, preventing postsubmit image build failures and enabling promotion of the latest tests-private image to the ci namespace.
  • Retained opm installation from the candidate mirror.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 24, 2026
@miyadav

miyadav commented Jul 24, 2026

Copy link
Copy Markdown
Member

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@miyadav

miyadav commented Jul 27, 2026

Copy link
Copy Markdown
Member

/retest

@miyadav

miyadav commented Jul 27, 2026

Copy link
Copy Markdown
Member

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@miyadav

miyadav commented Jul 30, 2026

Copy link
Copy Markdown
Member

/retest

@miyadav

miyadav commented Jul 30, 2026

Copy link
Copy Markdown
Member

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't checkout base SHA b235e417ec59c1548b0b69a069146fcbd0800978: error checking out "b235e417ec59c1548b0b69a069146fcbd0800978": exit status 128 fatal: unable to read tree (b235e417ec59c1548b0b69a069146fcbd0800978)

redhat-chai-bot and others added 2 commits July 30, 2026 13:31
Change the oc-mirror download URL from ocp-dev-preview/latest (which no
longer hosts the file) to ocp/candidate. This fixes the postsubmit
image build job that was failing due to the missing tarball.
@redhat-chai-bot
redhat-chai-bot force-pushed the fix/remove-oc-mirror-from-tests-private branch from 78e4ea5 to 3bcfa49 Compare July 30, 2026 13:31
@miyadav

miyadav commented Jul 30, 2026

Copy link
Copy Markdown
Member

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@miyadav

miyadav commented Jul 30, 2026

Copy link
Copy Markdown
Member

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miyadav: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-openshift-tests-private-release-5.0-images-images openshift/openshift-tests-private presubmit Ci-operator config changed
pull-ci-openshift-openshift-tests-private-main-images-images openshift/openshift-tests-private presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@redhat-chai-bot

Copy link
Copy Markdown
Contributor Author

/pj-rehearse

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@miyadav

miyadav commented Jul 30, 2026

Copy link
Copy Markdown
Member

@memodi @sergiordlr , looking for labels on this to be merged to unblock push of openshift-test-private images ..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants