Repository navigation
Conversation
heroku-18's buildstep image hasn't been rebuilt since 2022 (CI build/push for it and cedar-14 was disabled 2025-05-21, see buildstep's .github/workflows). heroku-24 is the only actively-maintained stack, rebuilt regularly. Tested a real scraper end-to-end against the current openaustralia/buildstep:heroku-24 image - clean bundle install, no buildpack issues. Only affects the template written into brand-new Ruby scrapers created via CreateScraperWorker - existing scrapers (with or without their own platform file) are unaffected, since this file is only read once, at creation time. DEFAULT_PLATFORM (cedar-14, used when a scraper has no platform file at all) is untouched. Scoped to Ruby only for now - Node/PHP/Perl are known or suspected broken on heroku-24 (see Language::LANGUAGES_SUPPORTED's existing FIXME and #1443/#1444/#1448) and haven't been individually verified. Co-Authored-By: Claude Sonnet 5 <[email protected]>
This was referenced Sep 11, 2026
Br3nda
marked this pull request as ready for review
September 12, 2026 02:29
benrfairless
requested changes
Sep 16, 2026
benrfairless
left a comment
Member
There was a problem hiding this comment.
This can't be done while we are on the old server. It will need to wait until we are on the new server with newer docker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Changes the
platformfile in the Ruby scraper template (used when a new scraper is created via morph.io's "create a scraper" flow) fromheroku-18toheroku-24.Why was this needed?
heroku-18's buildstep image hasn't been rebuilt since 2022 - CI build/push for it (andcedar-14) was disabled on 2025-05-21 (seeopenaustralia/buildstep's workflow files, "disabling the older builds so the existing working images don't get disturbed").heroku-24is the only stack still actively rebuilt.Tested a real Ruby scraper end-to-end against the current
openaustralia/buildstep:heroku-24image: cleanbundle install, no buildpack issues.Scope - deliberately narrow
default_files/ruby/template/platformis read once, at creation time, byCreateScraperWorker- existing scrapers (with or without their ownplatformfile) are completely unaffected.DEFAULT_PLATFORM(cedar-14, used when a scraper has noplatformfile at all) is untouched - so old scrapers relying on that implicit default keep behaving exactly as they do today.heroku-24(see the existing# FIXME: get php and perl examples / buildstep working for heroku-24inLanguage, andopenaustralia/morph#1443/#1444/#1448) and haven't been individually re-verified - happy to do the same test-first pass on each if useful.default_files/python/template/platformwas alreadyheroku-24before this PR.Testing done
herokuish buildpack buildagainst a real scraper (unmodified Gemfile pinningruby "3.2.2") run directly againstopenaustralia/buildstep:heroku-24, pulled fresh:Opening as a draft while I sanity-check whether there's anything else worth doing alongside this (e.g. whether
update_docker_images!needs to run for the change to actually take effect on morph.io's build hosts).