Repository navigation
negotiator/skipping: parse parents before queueing - #150
Merged
Merged
Conversation
dreynaud-oai
approved these changes
Oct 19, 2026
ttaylorr-oai
force-pushed
the
tb/codex/skipping-parse-parents
branch
from
October 19, 2026 19:45
70b0823 to
2683778
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping negotiation sorts its queue by commit date, but can insert parents before parsing them. Their dates are still zero, so older ref tips take precedence. This can delay offering a recent common ancestor.
Parse previously unseen parents in
push_parent()before adding them to the queue. Parents that cannot be parsed stay out of the queue. The skip-distance rules remain unchanged.Add a regression test with a topic branch one commit ahead of master and 32 old ref tips. Master's parent must be the second commit offered, right after the topic tip.
The source branch starts at the fork's master so the release controller can replay the patch. The patch is unchanged by the rebase (
git range-diffreports equality). A separate commit retains the reviewed CI action pins.Validation:
t5552-skipping-fetch-negotiator.shandt5500-fetch-pack.shpass.t5540,t5549,t5550,t5552,t5563, andt5702, with HTTP support enabled.