Skip to content

http-fetch: reuse completed packs before downloading - #149

Merged
ttaylorr-oai merged 0 commit into
codexfrom
dr/codex/reuse-packfile-uri
Oct 19, 2026
Merged

ttaylorr-oai merged 0 commit into
codexfrom
dr/codex/reuse-packfile-uri

Conversation

@dreynaud-oai

@dreynaud-oai dreynaud-oai commented Oct 19, 2026 •

Copy link
Copy Markdown

A packfile URI can name a pack that is already installed locally. We still download that pack because http-fetch only looks for a partial download.

Open objects/pack/pack-<hash>.pack before starting HTTP. If we can open it, feed it to the requested index-pack command and report zero downloaded bytes. This preserves pack validation, index-pack output and keep-file handling while avoiding a second download.

Remove downloaded packs between HTTP authentication tests so later tests still make HTTP requests. Without that cleanup, pack reuse causes 15 failures in t5563.

The source branch starts at tn/codex/http-pack-transient-retry so the release controller can replay it. Daniel's patch is unchanged. A separate commit retains the reviewed CI action pins.

Validation:

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T19:21:12.102554Z 92f766d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@ttaylorr-oai
ttaylorr-oai force-pushed the dr/codex/reuse-packfile-uri branch from 92f766d to d5e2b6b Compare October 19, 2026 19:47
@ttaylorr-oai
ttaylorr-oai merged commit 9fe64f4 into codex Oct 19, 2026
89 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants