Repository navigation
http-fetch: reuse completed packs before downloading - #149
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ttaylorr-oai
approved these changes
Oct 19, 2026
ttaylorr-oai
force-pushed
the
dr/codex/reuse-packfile-uri
branch
from
October 19, 2026 19:47
92f766d to
d5e2b6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A packfile URI can name a pack that is already installed locally. We still download that pack because
http-fetchonly looks for a partial download.Open
objects/pack/pack-<hash>.packbefore starting HTTP. If we can open it, feed it to the requestedindex-packcommand and report zero downloaded bytes. This preserves pack validation,index-packoutput and keep-file handling while avoiding a second download.Remove downloaded packs between HTTP authentication tests so later tests still make HTTP requests. Without that cleanup, pack reuse causes 15 failures in
t5563.The source branch starts at
tn/codex/http-pack-transient-retryso the release controller can replay it. Daniel's patch is unchanged. A separate commit retains the reviewed CI action pins.Validation:
t5563,t5550, andt5702pass with HTTP enabled.t5563,t5702, and the pack reuse tests pass. Three older URL-credential tests int5550need the authentication fixes already present in codex.