feat(teams): acknowledge routed sends with activity IDs - #1494
Draft
NeoHsu wants to merge 8 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked draft: logical base
stack/teams-02-ingress-route-dedupeis PR #1493. GitHub requires an upstream PR base to exist inopenabdev/openab, so this draft temporarily targetsmainand may show preceding stack layers. Do not merge it until #1493 is merged and this branch is rebased onto currentmain; then review only its single incremental commit.What problem does this solve?
Replace optimistic send success with correlated Connector outcomes and real activity identifiers.
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365158868619404/1531339032527765655
Microsoft Teams roadmap discussion.
Review Contract
Goal
Replace optimistic send success with correlated Connector outcomes and real activity identifiers.
Non-goals
This PR does not guarantee visual quote rendering, add edit/delete operations, retry ambiguous POSTs, or persist activity ownership.
Accepted Residual Risks
A lost acknowledgement is Unknown even if Teams accepted the activity, and the client may render an explicit reply without visible quote UI.
Acceptance Criteria
Delivered sends include a non-empty real activity ID; malformed success responses become Unknown; rejected and timeout outcomes are explicit; no ambiguous send is retried; explicit quote targets cannot escape the authenticated route.
Follow-ups
Use real IDs for owned mutations, processing indicators, progressive responses, and later reconciliation.
At a Glance
Prior Art & Industry Research
OpenClaw: its Microsoft Teams extension separates access checks, Bot Framework route context, and outbound operations. For this slice the relevant comparison is outbound activity correlation and platform message identifiers.
Hermes Agent: its Teams platform adapter keeps Teams-specific transport and message shaping behind a platform adapter. It does not provide OpenAB’s negotiated Core/Gateway outcome contract, so this PR keeps the useful adapter boundary but adds explicit fail-closed semantics.
Proposed Solution
Why this approach?
Correlated real IDs are the minimum trustworthy foundation for later ownership, mutation, and cleanup behavior.
Alternatives Considered
Keep optimistic success (rejected: later mutation cannot prove ownership) or retry lost ACKs (rejected: duplicate sends).
Validation
cargo check -p openab-gateway --features teams