feat(teams): mutate bot-owned messages - #1495
Draft
NeoHsu wants to merge 9 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked draft: logical base
stack/teams-03-real-send-ackis PR #1494. GitHub requires an upstream PR base to exist inopenabdev/openab, so this draft temporarily targetsmainand may show preceding stack layers. Do not merge it until #1494 is merged and this branch is rebased onto currentmain; then review only its single incremental commit.What problem does this solve?
Allow Core to edit or delete only Teams activities that this Gateway instance delivered and owns.
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365158868619404/1531339032527765655
Microsoft Teams roadmap discussion.
Review Contract
Goal
Allow Core to edit or delete only Teams activities that this Gateway instance delivered and owns.
Non-goals
Inbound-message mutation, cross-conversation targets, durable ownership across restart, and general retry queues are excluded.
Accepted Residual Risks
Ownership is process-local. Unknown mutation outcomes preserve ownership for later reconciliation and are not retried; one explicit bounded 429 delay is the only transport retry.
Acceptance Criteria
Targets are explicit and scope checked; only real bot-owned IDs can mutate; same-conversation writes serialize without blocking unrelated conversations; Delivered/Rejected/Unknown are preserved through both deployment modes.
Follow-ups
Build processing and progressive lifecycle behavior on these primitives; consider persistent ownership separately.
At a Glance
Prior Art & Industry Research
OpenClaw: its Microsoft Teams extension separates access checks, Bot Framework route context, and outbound operations. For this slice the relevant comparison is bot-owned outbound mutation boundaries.
Hermes Agent: its Teams platform adapter keeps Teams-specific transport and message shaping behind a platform adapter. It does not provide OpenAB’s negotiated Core/Gateway outcome contract, so this PR keeps the useful adapter boundary but adds explicit fail-closed semantics.
Proposed Solution
429 Retry-Afterretry and serialize same-conversation writes.Why this approach?
Ownership and route checks happen before HTTP so a malformed or cross-scope target cannot become a platform side effect.
Alternatives Considered
Allow arbitrary message IDs (rejected: cross-scope mutation) or persist ownership now (deferred to a separately reviewed design).
Validation
cargo check -p openab-corecargo check -p openab-gateway --features teams