feat(gateway): negotiate platform delivery capabilities - #1490
Draft
NeoHsu wants to merge 4 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked draft: logical base
docs/teams-adr-commands-proactiveis PR #1489. GitHub requires an upstream PR base to exist inopenabdev/openab, so this draft temporarily targetsmainand may show preceding stack layers. Do not merge it until #1489 is merged and this branch is rebased onto currentmain; then review only its single incremental commit.What problem does this solve?
Let Core make delivery and streaming decisions from negotiated adapter capabilities instead of platform-name assumptions.
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365158868619404/1531339032527765655
Microsoft Teams roadmap discussion.
Review Contract
Goal
Let Core make delivery and streaming decisions from negotiated adapter capabilities instead of platform-name assumptions.
Non-goals
This PR does not harden Teams HTTP transport, add route state, require write acknowledgements, or enable any new user-facing feature.
Accepted Residual Risks
Old peers still use an explicit legacy fallback and cannot provide authoritative write outcomes. Capability additions require Core-first rollout for later coupled features.
Acceptance Criteria
Hello fields remain additive and fail closed when absent; legacy LINE/LINE WORKS behavior is preserved; Unified and Standalone derive equivalent capabilities; all affected code and schema references compile and resolve.
Follow-ups
Use the negotiated contract in the later dispatch, acknowledgement, mutation, reaction, and persistent-delivery PRs.
At a Glance
Prior Art & Industry Research
OpenClaw: its Microsoft Teams extension separates access checks, Bot Framework route context, and outbound operations. For this slice the relevant comparison is adapter capability boundaries and explicit platform behavior.
Hermes Agent: its Teams platform adapter keeps Teams-specific transport and message shaping behind a platform adapter. It does not provide OpenAB’s negotiated Core/Gateway outcome contract, so this PR keeps the useful adapter boundary but adds explicit fail-closed semantics.
Proposed Solution
Why this approach?
An additive handshake keeps old peers working while removing hidden platform-name assumptions from later delivery decisions.
Alternatives Considered
Keep platform-name allowlists (rejected: they cannot describe per-adapter outcomes) or require an immediate protocol break (rejected: unsafe rolling upgrades).
Validation
cargo check -p openab-corecargo check -p openab-gateway --features teams