fix(teams): reject unsupported gateway commands - #1491
Draft
NeoHsu wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Stacked draft: logical base
stack/teams-00-capabilitiesis PR #1490. GitHub requires an upstream PR base to exist inopenabdev/openab, so this draft temporarily targetsmainand may show preceding stack layers. Do not merge it until #1490 is merged and this branch is rebased onto currentmain; then review only its single incremental commit.What problem does this solve?
Prevent unsupported Teams control commands from being rendered as user-visible messages.
Discord Discussion URL: https://discord.com/channels/1491295327620169908/1491365158868619404/1531339032527765655
Microsoft Teams roadmap discussion.
Review Contract
Goal
Prevent unsupported Teams control commands from being rendered as user-visible messages.
Non-goals
No Connector HTTP policy, route persistence, reaction implementation, or command UX is added.
Accepted Residual Risks
Legacy reaction command forms remain no-ops until the opt-in reaction slice lands; this preserves compatibility without claiming delivery.
Acceptance Criteria
Unknown or unsupported commands return an error before any platform send, while ordinary content replies and the documented compatibility forms retain their prior behavior.
Follow-ups
Add negotiated reaction support and richer commands only in their dedicated PRs.
At a Glance
Prior Art & Industry Research
Not applicable — this is a narrow bug fix that prevents an unsupported control command from falling through to ordinary content delivery.
Proposed Solution
Why this approach?
Failing before content dispatch is the smallest compatible fix and prevents control data from becoming a visible message.
Alternatives Considered
Continue treating unknown commands as sends (rejected: user-visible control leakage) or silently ignore every command (rejected: hides incompatibility).
Validation
cargo check -p openab-gateway --features teams