Skip to content

Build on the .NET 11 SDK and bootstrap the toolchain with mise - #45

Merged
Mpdreamz merged 1 commit into
mainfrom
feature/nullean-standard
Nov 11, 2026
Merged

Mpdreamz merged 1 commit into
mainfrom
feature/nullean-standard

Conversation

@Mpdreamz

Copy link
Copy Markdown
Contributor

Builds cdp on the .NET 11 SDK, lets mise install the toolchain (the SDK, the net10.0 runtime and Node) the same way locally and in CI, gives the repository the mise run tasks every nullean repository shares, and runs zizmor over the workflows.

Prompt summary: Bring every nullean repository onto one standard: .NET 11, global.json, mise for bootstrapping SDKs, the same mise run task names, and zizmor on every repository's workflows.

Why

Each nullean repository set up its toolchain its own way, and its workflows pinned actions by mutable tags. One standard means one set of commands to learn, one place (global.json) that names the SDK, and a static check that catches workflow injection and credential leaks before they ship.

What

The SDK and mise

global.json now names SDK 11.0.100 (latest feature band, no prereleases); the Microsoft.Testing.Platform test section stays. mise.toml reads the SDK version from global.json and adds the net10.0 runtime every project and test still targets, plus Node 24 for js/journeys. cdp has no build project, so the tasks (build, test, pack, ci, docs, check) run the exact commands CI runs; ci covers both the .NET build job and the journeys job. check is zizmor only for now: curb formatting comes in a later step.

CI setup

Every job that set up .NET now uses mise-action, with its cache off because this workflow publishes what it builds, and one install at a time because parallel dotnet installs into one DOTNET_ROOT race on Linux. The release job has no checkout, so the action writes a one-line mise.toml asking for the same dotnet 10 it used before. The journeys job takes Node from mise too. The npm publish job keeps setup-node, whose registry-url the trusted publishing setup relies on, pinned by SHA and with its package cache switched off, which zizmor flagged as cache poisoning in a publishing job.

Workflow hardening

Every action is pinned by commit SHA with a comment naming the tag it points at, staying within each action's current major apart from checkout (v7, as in the other repositories). Checkouts no longer keep credentials, since none of them push. A zizmor job calls the shared nullean/.github workflow. One existing ls | sed line got a shellcheck suppression so actionlint passes clean. When and how releases publish (the tag trigger, the release environment, trusted publishing from ci.yml) is unchanged.

SDK 11 analyzers

SDK 11's IDE0028 asks for [with(StringComparer.Ordinal), ...] where a collection was built with a comparer, and under warnings-as-errors that failed the build in two places. Those are the only code changes; the using re-sort dotnet format also made was reverted.

Out of scope: central package management and package metadata, the release-drafter release flow, moving tests off net10.0, upgrading artifact and Pages actions to new majors (the jobs that use them only run on main and tags, so a PR cannot test them), and curb formatting.

Verify

  • Baseline on origin/main (SDK 10.0.403), with Chrome and CDP_BROWSER_REQUIRED=1: dotnet build -c Release then dotnet test -c Release --no-build gave 517 total, 517 passed, 0 skipped. npm test gave 419 passed, npm run test:live 4 passed. Both library packages packed.
  • After, on SDK 11.0.100: mise trust -q . && mise run ci gave the same counts: 517/517/0, 419 passed, 4 passed, the same two packages.
  • GH_TOKEN=$(gh auth token) zizmor --min-severity medium . reports no findings; mise exec shellcheck@latest -- actionlint .github/workflows/*.yml is clean.
  • Not run locally: the AOT pack, tool pack and tool smoke jobs, the release jobs and the Pages deploy. They only run on main or tags.

🤖 Generated with Claude Code

Every nullean repository is moving onto one standard: the SDK pinned in
global.json, mise installing it (and here Node) the same way locally and in
CI, the same `mise run` task names everywhere, and zizmor checking the
workflows.

cdp has no build project, so the mise tasks run the commands CI already
runs. The net10.0 runtime is listed after the SDK because every project
still targets net10.0, and mise installs only what is listed.

CI swaps setup-dotnet for mise-action with its cache off (this workflow
publishes what it builds) and installs one dotnet at a time, since parallel
installs into one DOTNET_ROOT race. The journeys job takes Node from mise
too; the npm publish job keeps setup-node, whose registry-url the trusted
publishing setup relies on, now with its package cache off. Actions are
pinned by SHA and checkouts drop their credentials. Releases are unchanged.

SDK 11's IDE0028 rewrites two comparer-taking collections as
[with(StringComparer.Ordinal), ...]; under warnings-as-errors they failed
the build.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@Mpdreamz Mpdreamz added the ci Build and automation (patch) label Nov 11, 2026
@Mpdreamz
Mpdreamz merged commit 8da24b9 into main Nov 11, 2026
12 checks passed
@Mpdreamz
Mpdreamz deleted the feature/nullean-standard branch November 11, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Build and automation (patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant