Repository navigation
Build on the .NET 11 SDK and bootstrap the toolchain with mise - #45
Merged
Merged
Conversation
Every nullean repository is moving onto one standard: the SDK pinned in global.json, mise installing it (and here Node) the same way locally and in CI, the same `mise run` task names everywhere, and zizmor checking the workflows. cdp has no build project, so the mise tasks run the commands CI already runs. The net10.0 runtime is listed after the SDK because every project still targets net10.0, and mise installs only what is listed. CI swaps setup-dotnet for mise-action with its cache off (this workflow publishes what it builds) and installs one dotnet at a time, since parallel installs into one DOTNET_ROOT race. The journeys job takes Node from mise too; the npm publish job keeps setup-node, whose registry-url the trusted publishing setup relies on, now with its package cache off. Actions are pinned by SHA and checkouts drop their credentials. Releases are unchanged. SDK 11's IDE0028 rewrites two comparer-taking collections as [with(StringComparer.Ordinal), ...]; under warnings-as-errors they failed the build. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds cdp on the .NET 11 SDK, lets mise install the toolchain (the SDK, the net10.0 runtime and Node) the same way locally and in CI, gives the repository the
mise runtasks every nullean repository shares, and runs zizmor over the workflows.Prompt summary: Bring every nullean repository onto one standard: .NET 11, global.json, mise for bootstrapping SDKs, the same mise run task names, and zizmor on every repository's workflows.
Why
Each nullean repository set up its toolchain its own way, and its workflows pinned actions by mutable tags. One standard means one set of commands to learn, one place (global.json) that names the SDK, and a static check that catches workflow injection and credential leaks before they ship.
What
The SDK and mise
global.json now names SDK 11.0.100 (latest feature band, no prereleases); the Microsoft.Testing.Platform
testsection stays. mise.toml reads the SDK version from global.json and adds the net10.0 runtime every project and test still targets, plus Node 24 forjs/journeys. cdp has no build project, so the tasks (build,test,pack,ci,docs,check) run the exact commands CI runs;cicovers both the .NET build job and the journeys job.checkis zizmor only for now: curb formatting comes in a later step.CI setup
Every job that set up .NET now uses mise-action, with its cache off because this workflow publishes what it builds, and one install at a time because parallel dotnet installs into one DOTNET_ROOT race on Linux. The release job has no checkout, so the action writes a one-line mise.toml asking for the same dotnet 10 it used before. The journeys job takes Node from mise too. The npm publish job keeps setup-node, whose
registry-urlthe trusted publishing setup relies on, pinned by SHA and with its package cache switched off, which zizmor flagged as cache poisoning in a publishing job.Workflow hardening
Every action is pinned by commit SHA with a comment naming the tag it points at, staying within each action's current major apart from checkout (v7, as in the other repositories). Checkouts no longer keep credentials, since none of them push. A zizmor job calls the shared nullean/.github workflow. One existing
ls | sedline got a shellcheck suppression so actionlint passes clean. When and how releases publish (the tag trigger, thereleaseenvironment, trusted publishing from ci.yml) is unchanged.SDK 11 analyzers
SDK 11's IDE0028 asks for
[with(StringComparer.Ordinal), ...]where a collection was built with a comparer, and under warnings-as-errors that failed the build in two places. Those are the only code changes; the using re-sortdotnet formatalso made was reverted.Out of scope: central package management and package metadata, the release-drafter release flow, moving tests off net10.0, upgrading artifact and Pages actions to new majors (the jobs that use them only run on main and tags, so a PR cannot test them), and curb formatting.
Verify
CDP_BROWSER_REQUIRED=1:dotnet build -c Releasethendotnet test -c Release --no-buildgave 517 total, 517 passed, 0 skipped.npm testgave 419 passed,npm run test:live4 passed. Both library packages packed.mise trust -q . && mise run cigave the same counts: 517/517/0, 419 passed, 4 passed, the same two packages.GH_TOKEN=$(gh auth token) zizmor --min-severity medium .reports no findings;mise exec shellcheck@latest -- actionlint .github/workflows/*.ymlis clean.🤖 Generated with Claude Code