Skip to content

Release by publishing the release-drafter draft - #47

Merged
Mpdreamz merged 1 commit into
mainfrom
feature/release-from-draft
Nov 11, 2026
Merged

Mpdreamz merged 1 commit into
mainfrom
feature/release-from-draft

Conversation

@Mpdreamz

Copy link
Copy Markdown
Contributor

cdp now releases when its release-drafter draft is published (on github.com, from a phone, or with mise run release publish), not when a tag is pushed. Each pull request carries exactly one label, and that label decides the next version.

Prompt summary: Bring every nullean repository onto one standard: .NET 11, global.json, mise for bootstrapping SDKs, the same mise run task names, and zizmor on every repository's workflows. This step makes every repository release the same way: release-drafter drafts the notes from required PR labels, in 0.x a breaking change bumps the minor version, and releasing means promoting the draft.

Why

A release meant pushing a tag by hand and choosing its version, and gh release create --generate-notes wrote the notes from whatever had merged since the last tag. Nothing required a PR label, so the notes and the next version depended on the person tagging.

What

Release from the draft

ci.yml replaces its tag trigger with release: published. The release (NuGet) and publish-npm jobs now run when github.event_name == 'release', after the same jobs as before. They stay in ci.yml and in the release environment, because the trusted publishing policies on nuget.org and npm name that file and that environment, and that environment only lets tags deploy (a published release's ref is its tag). The release now exists before the job runs (it is the published draft), so the job no longer creates one. It attaches the packages with gh release upload --clobber, which a re-run can repeat. The cdp release jobs stay bespoke rather than calling the shared release.yml, because they publish native AOT tool packages per RID plus npm.

Drafts, labels and dependency updates

release-drafter.yml keeps the draft current on every push to main. .github/release-drafter.yml maps labels to versions: breaking, feature and enhancement bump the minor version (the 0.x rule), and everything else is a patch. pr-labels.yml fails a PR without exactly one release label. Both call the shared workflows pinned at v1.3.0. The label set was synced in #45. dependabot.yml updates NuGet, npm (js/journeys) and actions weekly in groups, with a 7-day cooldown and the dependencies label.

Skills and docs

The releasing, breaking-changes and upgrade-deps skills come from the template, with one line in releasing about the npm job. The pr skill comes too, with the commit skill and writing-style.md it links to. mise run release shows the draft and mise run release publish publishes it. AGENTS.md has a releasing section, and the DECISIONS.md release entry now describes the new flow.

Out of scope: making release-label a required check in branch protection, curb formatting (the template's format skill is left out until that step), and the template's issue skill.

Verify

  • mise run ci with Chrome and CDP_BROWSER_REQUIRED=1: 517/517 .NET tests passed (0 skipped), npm 419 passed, Playwright 4 passed. These are the same counts as on main.
  • zizmor --min-severity medium . reports no findings; actionlint is clean.
  • mise run release reports no draft yet, as expected until a labelled PR merges after this one.
  • Not run: the release jobs themselves. They run only when a draft is published.

🤖 Generated with Claude Code

A release meant pushing a tag by hand and choosing its version, and the
release notes were generated from whatever had merged, labelled or not.
Now release-drafter keeps a draft current from the labels of merged pull
requests, pr-labels makes every pull request carry exactly one, and
publishing the draft is the release: it creates the tag and fires
`release: published` on ci.yml. A pushed tag alone no longer releases.

The NuGet and npm release jobs stay in ci.yml, in the `release`
environment, because the trusted publishing policies on nuget.org and npm
name that file and that environment. The GitHub release is the published
draft, so the job no longer creates one; it attaches the packages with
`gh release upload --clobber`, which a re-run can repeat safely.

Dependabot updates NuGet, npm (js/journeys) and actions weekly. The
releasing, breaking-changes and upgrade-deps skills describe the flow, and
`mise run release` shows the draft.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@Mpdreamz Mpdreamz added the ci Build and automation (patch) label Nov 11, 2026
@Mpdreamz
Mpdreamz merged commit 5059e21 into main Nov 11, 2026
12 checks passed
@Mpdreamz
Mpdreamz deleted the feature/release-from-draft branch November 11, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Build and automation (patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant