Repository navigation
chore(deps): bump grpc 1.83.1 and x/crypto 0.56.0 to clear govulncheck - #158
Merged
Merged
Conversation
GO-2026-6348 (grpc) and GO-2026-6354/6355 (x/crypto) fail the vuln job on every PR. x/crypto 0.56.0 requires go 1.26, so the go directive moves to 1.26.6, matching the Dockerfile build image; 1.26.0 would pull in stdlib vulns fixed in later patches.
v2.7.2 is built with go1.25 and refuses to load a go 1.26 module. The newer staticcheck flags the deprecated DetectOptions.CredentialsFile (now loaded via NewCredentialsFromJSON with the file's declared type) and an SA6001 false positive in a test helper.
5 of 12 tasks
blue4209211
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
vulnCI job fails on every open PR (#153–#157) because of:x/crypto 0.56.0 requires Go 1.26, so the
godirective moves from 1.25.13 to 1.26.6. That matches the Dockerfile build image (golang:1.26.6). Pinning1.26.0would make CI (go-version-file: go.mod) install a toolchain with stdlib vulnerabilities that were fixed in later 1.26 patches.Type of change
How Has This Been Tested?
Under go1.26.6,
go test ./...passes,govulncheck ./...exits 0, andgolangci-lintreports 0 issues.Checklist
make validatepasses (fmt + lint + test)