Skip to content

ci(release): golangci-lint v2.13.2 to match ci.yml - #159

Merged
blue4209211 merged 1 commit into
mainfrom
fix/release-golangci-lint-go126
Sep 25, 2026
Merged

blue4209211 merged 1 commit into
mainfrom
fix/release-golangci-lint-go126

Conversation

@mayankpande88

Copy link
Copy Markdown
Contributor

Description

The Release workflow is failing on main at the Lint step:

can't load config: the Go language version (go1.25) used to build golangci-lint is lower than the targeted Go version (1.26.6)

#158 and #157 moved go.mod to Go 1.26 and bumped golangci-lint in ci.yml to v2.13.2, but release.yml pins its own copy, still v2.7.2. This PR bumps that copy to v2.13.2 and adds a comment in both workflows to keep the two versions in sync.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves existing functionality)
  • Refactor (non-breaking change which improves code structure)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • CI/CD

How Has This Been Tested?

  • Unit tests
  • Manual testing

ci.yml has used v2.13.2 on #157 and #158, where it passed against the same code that is now on main. After merge, the Release run triggered by the push to main confirms the fix.

Checklist

  • CLA signed (the CLA bot will prompt on your first PR)
  • make validate passes (fmt + lint + test)
  • Docs updated if the wire shape, config surface, or proxy module behavior changed

The go directive moved to 1.26 in #158/#157, but release.yml still pinned
golangci-lint v2.7.2, which is built with go1.25 and refuses to load the
module, so the Release workflow fails on main.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@blue4209211
blue4209211 merged commit b54dedd into main Sep 25, 2026
6 checks passed
@blue4209211
blue4209211 deleted the fix/release-golangci-lint-go126 branch September 25, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants