[P2][Bug] Post-0.50.1: preserve explicit pytest file selection in portable reviews #480

Problem and release decision

Track the remaining P2 finding from release PR #477 for a version after Code Review 0.50.1. The maintainer explicitly deferred this finding in the review thread. The thread is resolved as deferred, not as fixed.

0.50.1 is frozen: do not modify or replace its source, signed bundle, signatures, or registry artifacts for this ticket. This follow-up does not block the agreed 0.50.1 promotion.

Outstanding finding — P2: preserve explicitly selected test files

• Original annotation: release: publish Code Review 0.50.1 portable project runtimes #477 (comment)
• Affected version: specfact-code-review 0.50.1.
• Reviewed release head: 3d6e984f8d3609559a5f6ecba910167e6cdd5edd.
• Location: select_test_paths, portable_worker.py:123–140.

A selected pytest file such as tests/checks.py is treated as production source when its basename does not match python_files. The selector then either substitutes a conventional matching test or raises project_test_selection_empty. An intended failing test can therefore be omitted from the review evidence.

Expected: preserve explicit pytest test-file selection using native pytest semantics, including filenames outside automatic discovery patterns. Keep ordinary production-source-to-test mapping distinct; do not indiscriminately execute every reviewed Python source file as a test.

Reproduction to turn into a regression

1. Create a disposable Python project with default pytest filename patterns and tests/checks.py containing def test_selected(): assert False.
2. Establish the native baseline with python -m pytest tests/checks.py: the explicitly supplied file should be collected and fail.
3. Select the same test file for a portable capsule review. Verify the target worker receives and executes it rather than reporting project_test_selection_empty.
4. Repeat with a passing tests/test_checks.py present. The conventional file must not replace or conceal the explicitly selected failing file.
5. Repeat with custom python_files patterns and a mixed source/test review.

Evidence status: the annotation and current selector branch were inspected on 2026-09-17 (Europe/Berlin). Static inspection supports the finding. These reproduction steps are proposed regression cases, not a claim that an end-to-end capsule reproduction has already run. Confidence: high in the selection mismatch; end-to-end impact remains to be recorded during implementation.

Acceptance criteria

• Specify explicit test-target semantics separately from automatic source-to-test discovery before implementation.
• Record failing-before evidence for default/custom filename patterns, no conventional match, competing conventional test, and mixed source/test selection.
• Preserve explicit test targets and native pytest configuration precedence without silent substitution or omission.
• Keep source mapping, repository containment, exclusions, and supported selection controls intact.
• Run the failing explicit-file fixture through the real capsule; prove actual collection, execution, and failing-test evidence. A skipped required analysis must not become PASS.
• Record passing-after regression and relevant integration evidence, including ordinary conventionally named tests and full discovery.
• Deliver through a separate reviewed change and a new signed module version using canonical CI publication; leave immutable 0.50.1 artifacts unchanged.

Review triage ledger

Ownership and scope

• Parent: Feature Validation Evidence And Governance Runtime Follow-Ups #163, within Epic specfact code / AI-bloat defense #162.
• Related delivery: [User Story] Portable capsule review with automatic external project runtimes #473 and OpenSpec code-review-16-portable-project-runtime; original customer defect [Bug] Capsule review fails closed on external Hatch projects without project-runtime handoff #472 remains separate and is not closed by this reconstructed fixture.
• Assignee: @djm81. Priority: P2. Status: Todo / deferred after 0.50.1.
• No new OpenSpec change or implementation is created by this triage ticket. Select and validate a follow-up change when implementation starts.
• No known blocking dependencies for triage; do not make this ticket a release blocker for release: publish Code Review 0.50.1 portable project runtimes #477.