Repository navigation
Conversation
fix(pbs): launch unified commit-boost binary on v0.10+
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
start-pbs.shnow runs/usr/local/bin/commit-boost pbswhen that binary exists, and falls back to/usr/local/bin/commit-boost-pbsfor the v0.9.x image that Hyperdrive still defaults to.exec: not found.CB_CONFIG=/cb_config.toml).Fixes the crash-loop when a user sets the Commit-Boost container tag to v0.10.0 or newer:
/usr/share/hyperdrive/scripts/start-pbs.sh: 15: exec: /usr/local/bin/commit-boost-pbs: not foundCommit-Boost v0.10.0 unified the CLI, PBS, and signer into one binary (
commit-boost-client#425). The v0.11.0 PBS image entrypoint iscommit-boost pbs(instead ofcommit-boost-pbs).This does not bump the default container tag. v0.11.0 also drops the Builder API v2-to-v1 fallback and requests SSZ from relays first, so that should be a separate change.
Test plan
v0.11.0, replacing the exec withcommit-boost pbsstops the exit-127 loop.hyperdrive service startagainst the default v0.9.2 image still launchescommit-boost-pbs.v0.11.0launchescommit-boost pbs, registers with the configured relays, and stays up.