Skip to content

v8: support simdutf without atomic_ref #65775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
luoqianlin wants to merge 1 commit into from
+13 −0
Closed

v8: support simdutf without atomic_ref #65775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions deps/v8/src/builtins/builtins-typed-array.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,10 +506,17 @@ simdutf::result ArrayBufferSetFromBase64(
output_length = array_length;
simdutf::result simd_result;
if (typed_array->buffer()->is_shared()) {
#if SIMDUTF_ATOMIC_REF
simd_result = simdutf::atomic_base64_to_binary_safe(
reinterpret_cast<const T>(input_vector), input_length,
reinterpret_cast<char*>(typed_array->DataPtr()), output_length,
alphabet, last_chunk_handling, /*decode_up_to_bad_char*/ true);
#else
simd_result = simdutf::base64_to_binary_safe(
reinterpret_cast<const T>(input_vector), input_length,
reinterpret_cast<char*>(typed_array->DataPtr()), output_length,
alphabet, last_chunk_handling, /*decode_up_to_bad_char*/ true);
#endif
} else {
simd_result = simdutf::base64_to_binary_safe(
reinterpret_cast<const T>(input_vector), input_length,
Expand Down Expand Up @@ -836,9 +843,15 @@ BUILTIN(Uint8ArrayPrototypeToBase64) {

size_t simd_result_size;
if (uint8array->buffer()->is_shared()) {
#if SIMDUTF_ATOMIC_REF
simd_result_size = simdutf::atomic_binary_to_base64(
std::bit_cast<const char*>(uint8array->DataPtr()), length,
reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
#else
simd_result_size = simdutf::binary_to_base64(
std::bit_cast<const char*>(uint8array->DataPtr()), length,
reinterpret_cast<char*>(output->GetChars(no_gc)), alphabet);
#endif
} else {
simd_result_size = simdutf::binary_to_base64(
std::bit_cast<const char*>(uint8array->DataPtr()), length,
Expand Down
Loading