v8: support simdutf without atomic_ref - #65775
Closed
luoqianlin wants to merge 1 commit into
Closed
Conversation
Collaborator
|
Review requested:
|
Contributor
|
You'd need to send this to upstream V8, and once they accept the patch, we can cherry-pick it here |
Author
|
Closing this PR because the ordinary simdutf fallback is not equivalent for The underlying toolchain compatibility issue remains documented in #65771. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version
Current
mainat71f5b1cbf0540d1309d58ac181326e5b65f680c7Platform
What steps will reproduce the bug?
The Android NDK r27 libc++ headers do not provide
std::atomic_ref, soSIMDUTF_ATOMIC_REFis not defined. V8's TypedArray base64 builtinsunconditionally call simdutf's optional
atomic_*APIs for SharedArrayBufferinputs and fail to compile.
What do you see instead?
What is the expected behavior?
The base64 builtins should compile with standard libraries that do not provide
std::atomic_ref. Platforms withSIMDUTF_ATOMIC_REFcontinue to use theatomic simdutf APIs; other platforms use the regular simdutf APIs.
Additional information
The change is limited to V8's two SharedArrayBuffer base64 call sites. It does
not change behavior on platforms where
SIMDUTF_ATOMIC_REFis available anddoes not depend on an Android device, system image, or local checkout path.