Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Retrospective.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,7 @@ Routing: narrative stays here. A project-specific rule that will recur may becom
- **What:** The package gate reported every file missing although the real npm12 dry-run listed the complete artifact.
- **Why:** The parser sliced braces and assumed the artifact itself was the JSON root; npm now groups artifacts by package name.
- **Fix:** Parse the complete JSON container, require exactly one artifact with the expected name/version, then retain every existing file/export/hash check. The real local package check passed after the correction.

## 2026-10-04: Fixture declarations are independent dependency targets

The dependency-duty draft initially compared issues #517–#519 with the root Bun lock. Independent review identified that their current bodies explicitly target uninstalled consumer fixtures. Reading those manifests confirmed stale Node types, Lucide and Vite declarations; the root lock did not describe those installations. The draft was corrected before any disposition comment or PR was published. Future triage must resolve every issue workspace and declared-only occurrence before assigning already-satisfied. Verify the copied external consumers with their own package manager, typecheck, build and dependency scan, while retaining all normal CI consumer gates.
4 changes: 2 additions & 2 deletions fixtures/next19/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
"lucide-react": "1.47.0",
"lucide-react": "1.48.0",
"next": "16.3.6",
"react": "19.3.0",
"react-dom": "19.3.0"
},
"devDependencies": {
"@types/node": "26.6.2",
"@types/node": "26.6.3",
"@types/react": "19.3.0",
"@types/react-dom": "19.3.0",
"typescript": "7.0.2"
Expand Down
4 changes: 2 additions & 2 deletions fixtures/vite-heavy/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"dependencies": {
"@tanstack/react-table": "9.2.4",
"lucide-react": "1.47.0",
"lucide-react": "1.48.0",
"react": "19.3.0",
"react-day-picker": "10.0.1",
"react-dom": "19.3.0",
Expand All @@ -20,6 +20,6 @@
"@types/react-dom": "19.3.0",
"@vitejs/plugin-react-swc": "4.3.3",
"typescript": "7.0.2",
"vite": "8.3.0"
"vite": "8.3.1"
}
}
4 changes: 2 additions & 2 deletions fixtures/vite-standalone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
"lucide-react": "1.47.0",
"lucide-react": "1.48.0",
"react": "19.3.0",
"react-dom": "19.3.0"
},
Expand All @@ -17,6 +17,6 @@
"@types/react-dom": "19.3.0",
"@vitejs/plugin-react-swc": "4.3.3",
"typescript": "7.0.2",
"vite": "8.3.0"
"vite": "8.3.1"
}
}
4 changes: 2 additions & 2 deletions fixtures/vite-tailwind/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"typecheck": "tsc -p tsconfig.json --noEmit"
},
"dependencies": {
"lucide-react": "1.47.0",
"lucide-react": "1.48.0",
"react": "19.3.0",
"react-dom": "19.3.0"
},
Expand All @@ -19,6 +19,6 @@
"@vitejs/plugin-react-swc": "4.3.3",
"tailwindcss": "4.3.3",
"typescript": "7.0.2",
"vite": "8.3.0"
"vite": "8.3.1"
}
}
4 changes: 2 additions & 2 deletions scripts/consumer-gate.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ import "@nocoo/basalt/styles/tailwind";`),
assertTemplateManifest(manifest);
expect(manifest).toContain('"react": "19.3.0"');
expect(manifest).toContain('"react-dom": "19.3.0"');
expect(manifest).toContain('"lucide-react": "1.47.0"');
expect(manifest).toContain('"vite": "8.3.0"');
expect(manifest).toContain('"lucide-react": "1.48.0"');
expect(manifest).toContain('"vite": "8.3.1"');
assertRootConsumerSource(readFileSync("fixtures/vite-standalone/src/main.tsx", "utf8"));
assertStandaloneTypecheckGate(
readFileSync("fixtures/vite-standalone/tsconfig.json", "utf8"),
Expand Down
Loading