fix(topbar): replace placeholder logo - #65
Merged
Merged
Conversation
The header carried a placeholder: a blue circle with a hand-drawn cloud shape inside it. It is not our logo, and it is the only brand mark on the page, so it read as the course's identity. Replaced with the official mark from the brand asset, white variant. White rather than Nextcloud blue because the header is navy (#003356) and the brand blue has too little contrast against it; white-on-dark is the official variant for exactly this case. The wordmark is deliberately left out - the text beside the mark already reads "Nextcloud Developer Course" - and the viewBox is the mark's own bounding box so it sits tight against that text. Kept the fill as a fixed hex rather than a Tailwind colour utility: the placeholder was recoloured by a class, which is the one thing a real logo must not be. AI-Assisted-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Anna Larch <[email protected]>
miaulalala
added
3. to review
miaulalala
changed the title
nickvergessen
removed their request for review
September 3, 2026 15:58
oleksandr-nc
approved these changes
Sep 7, 2026
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
# Conflicts: # components/TopBar.tsx Co-authored-by: miaulalala <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The header carried a placeholder: a blue circle with a hand-drawn cloud shape inside it. It is not our logo, and it is the only brand mark on the page, so it read as the course's identity.
What changed
components/TopBar.tsxnow renders the official Nextcloud mark, taken from the brand asset.--color-navy: #003356) and the brand blue#0082c9has too little contrast against it. White-on-dark is the official variant for this case, and it matches the wordmark text beside it.viewBoxis the mark's own bounding box (14.26 35.2 121.49 55.31), computed from the path rather than eyeballed, so it sits tight against the text with no stray padding.text-blue-600; recolouring is the one thing a real logo must not be subject to.aria-hiddenkept: the adjacent text names the link, so the mark is decorative.Verification
npx tsc --noEmitclean andnpm run buildsucceeds locally.Preview
The mark renders 24px tall against the navy bar, tight against the wordmark text, with the BETA pill and "Report an error" unchanged.