feat(topbar): add imprint and privacy links, and an AI declaration - #66
Open
miaulalala wants to merge 1 commit into
Open
feat(topbar): add imprint and privacy links, and an AI declaration#66miaulalala wants to merge 1 commit into
miaulalala wants to merge 1 commit into
Conversation
The site had no imprint, no privacy link and no statement about how the material was produced. Imprint and privacy go in the header rather than the footer, which is the part worth explaining: a German Impressum has to be permanently available and reachable from anywhere on the site, and the footer only exists on the homepage (CatalogClient), while TopBar renders on the catalog, level and module pages alike. Putting them in the header satisfies that today without extracting a shared footer first, so the footer rework stays a design task rather than a compliance one. Both links point at nextcloud.com so there is one canonical copy of the legal text to keep current, rather than a second copy here that can go stale. They are always rendered and never hidden behind a breakpoint - a legal link that disappears on a phone is not permanently available. That no longer fits one row on a narrow screen, so the header wraps instead of clipping: min-h-14 with flex-wrap, and the title takes its own row below sm. That in turn lets the abbreviated "NC Course" title go, since it only existed to fit alongside everything else. Verified at 320, 390, 768 and 1280px with no horizontal overflow. The AI declaration goes in the homepage footer instead. It is a statement about the content rather than a legal notice, so it carries no reachable-from-everywhere requirement and does not need to compete for header space. AI-Assisted-By: Claude Opus 5 (1M context) <[email protected]> Signed-off-by: Anna Larch <[email protected]>
miaulalala
added
3. to review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The site had no imprint, no privacy link, and no statement about how the material was produced.
Imprint and privacy go in the header, not the footer
That is the part worth explaining. A German Impressum has to be permanently available and reachable from anywhere on the site, and the footer only exists on the homepage (
CatalogClient), whileTopBarrenders on the catalog, level and module pages alike. Putting the links in the header satisfies that today without extracting a shared footer first - so the footer rework stays a design task rather than a compliance one./impressum/and/privacy/, both live) rather than restating the legal text here. One canonical copy to keep current, instead of a second one that can go stale.The header now wraps instead of clipping
With two more links, one row no longer fits on a narrow screen:
min-h-14withflex-wrap, and the title takes its own row belowsm. That in turn lets the abbreviated "NC Course" title go, since it only existed to fit alongside everything else - the full name fits a 390px viewport on its own row.Verified at 320, 390, 768 and 1280px, no horizontal overflow at any of them.
AI declaration
In the homepage footer rather than the header: it is a statement about the content, not a legal notice, so it carries no reachable-from-everywhere requirement and does not need to compete for header space. Stated plainly rather than as a badge, and accurate about both halves - the assistance and the review.
Notes for review
components/TopBar.tsx, as fix(topbar): replace placeholder logo #65 does, but in different hunks. Whichever merges second should rebase cleanly.main; fix(topbar): replace placeholder logo #65 replaces it with the official mark.npx tsc --noEmitclean,npm run buildsucceeds locally.Preview