Repository navigation
sync: upstream pstack 4ec7ffa, plus fixes from forks and upstream PRs - #25
Merged
Merged
Conversation
Remove the obsolete Make Bot UI patch hunk and Poteto Mode name rule because upstream now uses directory slugs. Refresh rules.sed for current runner defaults, reviewer fallbacks, and shipping verdicts. Translate the three new skill commands, including description triggers, and replace the help paragraph for another harness with omp installation guidance. Remove six stale-exempt.tsv entries for refreshed rules. Exempt the two Swarm sentences that upstream deleted, retaining their translations if those sentences return. Update both README skill counts to 59 total and 56 generated skills for this build.
With plugin.json at the plugin root, omp's agent-plugins provider claims the package. That provider checks skill frontmatter against a closed field set and skips every skill that has disable-model-invocation, icon, color, or globs. On omp 18.12.2 it skips 54 of the 56 skills, so skill://poteto-mode and /skill:how are unknown. The build no longer extracts pstack/plugin.json, and the plugin manifest check now fails when the file is present.
…to the owned setup-pstack
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
upstream-synchas failed daily since 2026-10-16, the port still carried several defects that fork authors and upstream PR authors had already found, and two port claims were wrong on omp 18.12.6. This PR supersedes #23 and #24 (raphaelnz) and takes #20's rules (sametaln), rebuilt rather than copied.What changed
plugins/pstack/plugin.json, then a rebuild at upstream4ec7ffa(59 skills, 23 playbooks, 24 principles). Upstream setup step 8 (formal-verification offer) ported into the ownedsetup-pstack.worktree-audit-omp.patchrewritten.safe(the patch had turned*/open|*/draftinto*OPEN*while jq lowercases the state).stat/date, drops thergdependency, writes no scratch file in the repo.hold-unpushed, and a failed session lookup lands inverify-recent-chat.omp-port/test-worktree-audit.sh, run by the gate.generalPurpose, backtickedTask, Cursor transcript layout,/add-pluginand Option+Enter prose are gone from shipped skills, and the gate fails if any returns./deslopno longer recommendsomp cleanse --all(which edits files repo-wide); the gate rejects it (Keep precommit diagnostics non-mutating and diff-scoped #20). The skills no longer claim ahubtool (absent on omp 18.12.6); the gate fails any such claim. The gate's mutation harness now requires each mutation's own check to report FAIL.guide claimscovers the skills, playbooks andcheck-plan.mjsnamed in guide Pt. 1 and 2./poteto-modepin state reloads onsession_start,session_switch,session_branch,session_tree(it went stale across/new,/fork,/resume). Newomp-port/smoke-plugin.mjsstarts real omp with no inference and asserts all skills register; newsmokeCI job runs it on omp v18.12.6 pinned by SHA-256.zzz-watch-pr-fixes,zzzz-check-plan-fix,zzzz-orch-lock-takeover): #746 (#664, #666, #684), #769, the check-plan half of #745, and #733 with a hardened takeover marker.Scope / not done
fable-deslop(needs RepoPrompt CE), and anything from dsebban/skills.allowDraftinpolicy.ts; if #592 merges first the #769 patch stops applying on the next sync. The patch header says so.stat/dateon Linux only.Blast radius
Every marketplace install gets the rebuilt skills, three new skills (statechart, two formal-verification), and the extension change on upgrade.
plugin.jsonis no longer shipped, so omp'somp-pluginsprovider loads all skills.Verification
bash omp-port/check-port.sh:check-port: PASS(reproducible, worktree audit, guide claims, rule staleness all PASS).bash omp-port/test-gate-mutations.sh: PASS, 15 mutations each rejected by its own check.bun omp-port/smoke-plugin.mjson omp 18.12.6: PASS, 59/59 skills,/poteto-mode on/offrecorded, pin reloaded onnew_session. Fails on the oldindex.jsand on upstream's realplugin.json.tsc --strictclean.modelon ataskitem: the live tool rejects it for every agent exceptseance("modelis only accepted for theseanceagent"), so the gate's no-per-call-model rule stands.