Repository navigation
Conversation
Collaborator
|
The rules and gate check from this PR are in #25: the three rules, the runtime unscoped-cleanup contract check and the isolated mutation, rebuilt at 4ec7ffa rather than taking the generated files. One change: I dropped the trailing backslash-dot on the 'Run /deslop before commit' rule because upstream continues the sentence, so it never matched. Closing as taken. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The deslop translations recommend
omp cleanse --allas diagnostics over a diff. The CLI describes a detect-and-fix operation. Running the recommendation spawned repository-wide fixers and changed unrelated files.Scope
omp-port/rules.sedwith unslop and non-mutating repository diagnostics scoped to the diff.Tradeoffs
The guidance leaves each repository to select its existing diagnostic commands. It invents no CLI flag or replacement tool. The runtime contract disallows this unscoped cleanup recommendation in generated skills and agents.
Blast radius
Three port source files and five generated Markdown files change. The cleanup CLI itself and the operator's installed plugin do not change. The upstream pin remains
e5136d8.Verification
bash omp-port/sync-upstream.sh rebuildcompleted with isolated GNU prerequisites.bash omp-port/check-port.shpassed, including reproducibility at the pinned source.bash omp-port/test-gate-mutations.shpassed. The unscoped cleanup mutation was rejected by the real fixture gate.An earlier local gate used BSD awk and emitted an interpreter error despite exiting zero. That run was discarded. The reported full pass used GNU awk and completed without that error.