Repository navigation
fix(port): stop carrying the Agent Plugins manifest - #24
Merged
AlexNegrescu26 merged 1 commit intoOct 22, 2026
Merged
Conversation
With plugin.json at the plugin root, omp's agent-plugins provider claims the package. That provider checks skill frontmatter against a closed field set and skips every skill that has disable-model-invocation, icon, color, or globs. On omp 18.12.2 it skips 54 of the 56 skills, so skill://poteto-mode and /skill:how are unknown. The build no longer extracts pstack/plugin.json, and the plugin manifest check now fails when the file is present.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With
plugin.jsonat the plugin root, omp'sagent-pluginsprovider claims the package and skips every skill whose frontmatter hasdisable-model-invocation,icon,color, orglobs. On omp 18.12.2 that is 54 of 56 skills, soskill://poteto-modeand/skill:howare unknown. Without the manifest, theomp-pluginsprovider loads the plugin'sskills/directory.Closes #21. Closes #22.
What changed
lib.shno longer extracts or copiespstack/plugin.json, andsync-upstream.shno longer writes its version.plugin manifestcheck now fails whenplugins/pstack/plugin.jsonexists.plugins/pstack/plugin.jsonand record the reason inPORTING.md.Scope
omp-pluginsreadspackage.jsonomp.skills. That is wrong. It reads theskills/directory, andPORTING.mdsays so.Tradeoffs
A
rules.sedrule could strip the four fields so the manifest passes validation. Then every hidden skill would become model-invocable.Blast Radius
This affects marketplace installs and upgrades. Users who deleted
plugin.jsonby hand see no change. #23 regeneratesplugin.jsonat 0.15.30, so whichever PR merges second needs a rebase that deletes that file.Verification
HOMEon omp 18.12.2, an install frommainprints 54Skipping skillwarnings inomp skill listand lists neitherpoteto-modenorhow. An install from this branch prints none and lists both.bash omp-port/check-port.shexits 0 in an Alpine container, withplugin manifest PASSandreproducible PASS.