Skip to content

fix(port): stop carrying the Agent Plugins manifest - #24

Merged
AlexNegrescu26 merged 1 commit into
negoro26:mainfrom
raphaelnz:fix/drop-agent-plugins-manifest
Oct 22, 2026
Merged

AlexNegrescu26 merged 1 commit into
negoro26:mainfrom
raphaelnz:fix/drop-agent-plugins-manifest

Conversation

@raphaelnz

Copy link
Copy Markdown
Contributor

Why

With plugin.json at the plugin root, omp's agent-plugins provider claims the package and skips every skill whose frontmatter has disable-model-invocation, icon, color, or globs. On omp 18.12.2 that is 54 of 56 skills, so skill://poteto-mode and /skill:how are unknown. Without the manifest, the omp-plugins provider loads the plugin's skills/ directory.

Closes #21. Closes #22.

What changed

  • lib.sh no longer extracts or copies pstack/plugin.json, and sync-upstream.sh no longer writes its version.
  • The plugin manifest check now fails when plugins/pstack/plugin.json exists.
  • Delete plugins/pstack/plugin.json and record the reason in PORTING.md.

Scope

Tradeoffs

A rules.sed rule could strip the four fields so the manifest passes validation. Then every hidden skill would become model-invocable.

Blast Radius

This affects marketplace installs and upgrades. Users who deleted plugin.json by hand see no change. #23 regenerates plugin.json at 0.15.30, so whichever PR merges second needs a rebase that deletes that file.

Verification

  • In a clean HOME on omp 18.12.2, an install from main prints 54 Skipping skill warnings in omp skill list and lists neither poteto-mode nor how. An install from this branch prints none and lists both.
  • bash omp-port/check-port.sh exits 0 in an Alpine container, with plugin manifest PASS and reproducible PASS.

With plugin.json at the plugin root, omp's agent-plugins provider claims
the package. That provider checks skill frontmatter against a closed field
set and skips every skill that has disable-model-invocation, icon, color,
or globs. On omp 18.12.2 it skips 54 of the 56 skills, so
skill://poteto-mode and /skill:how are unknown.

The build no longer extracts pstack/plugin.json, and the plugin manifest
check now fails when the file is present.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

agent-plugins validator drops 54 of 56 skills when plugin.json is present skill://poteto-mode calls

2 participants