Skip to content

chore(edit-sync): drop the stale mutation counts from the supersedesIdentity comment #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtskf merged 1 commit into from
Oct 2, 2026
Merged

chore(edit-sync): drop the stale mutation counts from the supersedesIdentity comment #430

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/webview/cm/edit-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,10 +401,9 @@ export function createEditSync(opts: EditSyncOptions): EditSync {
// until a same-generation foreign advance arrives. The named fields, not
// argument positions, are what keep the call sites readable and typo-proof;
// the DIRECTION is held by behaviour, not by the naming.
// Measured: swapping `from`/`to` reds 7 tests either way — the acksInFlightEdit
// swap reds 4 in cm-edit-sync.test.ts plus 2 in editor.test.ts's (d3) block
// and 1 in shell.test.ts; the shouldDropBufferedForEpoch swap reds 5 in
// cm-edit-sync.test.ts plus the same 2. Do not delete those in a tidy-up.
// Measured: swapping `from`/`to` at either call site reds tests across
// cm-edit-sync.test.ts, editor.test.ts and shell.test.ts. Those tests are what
// hold the direction — do not delete them in a tidy-up.
//
// Two consumers read it, and they MUST agree — that is the point of sharing
// one predicate rather than two hand-written copies. `shouldDropBufferedForEpoch`
Expand Down
Loading