chore(edit-sync): drop the stale mutation counts from the supersedesIdentity comment - #430
Merged
Merged
Conversation
…dentity comment The comment cited 5 + 2 red tests for the shouldDropBufferedForEpoch from/to swap; re-measured, the swap reds 22 tests across cm-edit-sync.test.ts, editor.test.ts and shell.test.ts. Counts drift with every added test, so name the files that hold the direction instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
supersedesIdentitycomment insrc/webview/cm/edit-sync.tscited how many tests go red whenfrom/tois swapped, and the figure for theshouldDropBufferedForEpochside was out of date. This rewrites the sentence so it no longer depends on a count.Changes
shouldDropBufferedForEpochand runningpnpm vitest runreds 22 tests across three files (13 incm-edit-sync.test.ts, 4 ineditor.test.ts, 5 inshell.test.ts), not the "5 + 2" the comment claimed.Related
edit-sync.tsのsupersedesIdentityコメントの mutation 件数を実測値に直す (found in the PR chore(protocol): require the Document epoch identity pair #429 review cycle)Test Plan
pnpm compile, lint andpnpm vitest rungreen on the final tree