Skip to content

chore(edit-sync): drop the stale mutation counts from the supersedesIdentity comment - #430

Merged
mtskf merged 1 commit into
mainfrom
chore/edit-sync-mutation-count-comment
Oct 2, 2026
Merged

mtskf merged 1 commit into
mainfrom
chore/edit-sync-mutation-count-comment

Conversation

@mtskf

@mtskf mtskf commented Oct 2, 2026

Copy link
Copy Markdown
Owner

Summary

The supersedesIdentity comment in src/webview/cm/edit-sync.ts cited how many tests go red when from/to is swapped, and the figure for the shouldDropBufferedForEpoch side was out of date. This rewrites the sentence so it no longer depends on a count.

Changes

  • Comment only — no code or test changes.
  • Re-measured: swapping the arguments in shouldDropBufferedForEpoch and running pnpm vitest run reds 22 tests across three files (13 in cm-edit-sync.test.ts, 4 in editor.test.ts, 5 in shell.test.ts), not the "5 + 2" the comment claimed.
  • Since any count drifts as tests are added, the comment now names the three test files that hold the direction and keeps the "do not delete them in a tidy-up" warning.

Related

Test Plan

  • Swap applied (asserted non-no-op), measured, then restored — the diff is the comment alone
  • pnpm compile, lint and pnpm vitest run green on the final tree

…dentity comment

The comment cited 5 + 2 red tests for the shouldDropBufferedForEpoch from/to swap; re-measured, the swap reds 22 tests across cm-edit-sync.test.ts, editor.test.ts and shell.test.ts. Counts drift with every added test, so name the files that hold the direction instead.
@mtskf
mtskf merged commit 9905d8d into main Oct 2, 2026
2 checks passed
@mtskf
mtskf deleted the chore/edit-sync-mutation-count-comment branch October 2, 2026 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant