Repository navigation
Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation - #2769
Conversation
… because go_to_bug doesn't wait for the module expand animation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The targeted wait correctly addresses the Firefox Selenium timing failure without affecting production behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds synchronization to go_to_bug so Selenium waits for module expansion animations before interacting with displayed fields.
Changes:
- Polls jQuery animation state for up to five seconds after expanding panels.
- Prevents Firefox ESR from reading temporarily clipped fields as empty.
| File | Description |
|---|---|
qa/t/lib/QA/Util.pm |
Waits for panel animations to finish in go_to_bug. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| unless $sel->driver->execute_script( | ||
| 'return window.jQuery ? jQuery(":animated").length : 0'); | ||
| select(undef, undef, undef, 0.1); | ||
| } |
There was a problem hiding this comment.
If we hit the 5 second cap the loop falls through silently and the test fails later with a confusing empty get_text. Could we emit a diag (or ok(0, ...)) when the animation never finishes so the failure points here?
Xzzz
left a comment
Xzzz
left a comment
There was a problem hiding this comment.
Looks good, and it fixes the failure I was seeing locally on an unrelated branch :)
Not blocking: I noticed that qa/t/2_test_flags.t:332 clicks action-expand-all and select flag values right after, so it doesn't get this wait. It passes today, but it's the same exposure. Maybe worth a small helper both can call? (in a follow-up)
* upstream/master: Bumped version to 20261006.1 Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation Revert "Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation (mozilla#2769)" Bug 2078352 - Selenium test 4_test_votes.t fails with Firefox ESR 153 because go_to_bug doesn't wait for the module expand animation (mozilla#2769) Bug 1273193 - Correct comments REST API documentation Bug 2059957 - Reject truncated request bodies before native endpoint dispatch Bug 2074690 - BMO REST API cannot set any DATE-type custom field
No description provided.